Emergency fix for ReDoS vulnerability #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zetlen Could you elaborate on the reason for disallowing subdomains? This used to work well in our setup, and now does not, as we require certificate generation for subdomains. From what I can see, this should not affect the ReDoS issue the original PR mitigates. |
|
@zetlen @davewasmer it breaks subdomain 😮 |
|
I think this change also also broke "localhost"... |
|
@zetlen Any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VALID_DOMAIN regex had exponential-time vulnerability on certain strings.
Switched from vulnerable VALID_DOMAIN regex to
is-valid-domainlib, which uses a known list of TLDs.