Skip to content

Conversation

@ndickson-nvidia
Copy link
Collaborator

Changelogs

  • val and test stage data was being clipped to the min and max values of the train stage, even when clipping was not enabled. In Graphium 2, clipping is only done when both a min and max clipping value are specified in the normalization options, even though those may not be the values used for clipping if the data range of the column doesn't span the whole clipping range. The behaviour should now match the behaviour of Graphium 2.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@ndickson-nvidia ndickson-nvidia changed the base branch from main to graphium_3.0 February 7, 2025 23:11
Copy link
Collaborator

@DomInvivo DomInvivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, you can merge

@ndickson-nvidia ndickson-nvidia merged commit ee601ea into graphium_3.0 Feb 11, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants