Skip to content

Conversation

@DomInvivo
Copy link
Collaborator

Changelogs

  • Removing support for IPU
  • Removing custom to_dense_batch and to_sparse_batch specific to IPUs, and reverted to the pyg version
  • Removing all documentation regarding IPUs

discussion related to that PR

@DomInvivo DomInvivo requested a review from WenkelF September 9, 2024 18:16
@DomInvivo DomInvivo changed the base branch from graphium_3.0 to torchmetrics September 9, 2024 18:19
@WenkelF
Copy link
Collaborator

WenkelF commented Sep 11, 2024

@DomInvivo, I have no concerns with the changes. The unit tests might need an overhaul though.

I resolved conflicts in order to run the env checks and they are failing (I believe due to issues with the installation of graphium_cpp).

@DomInvivo DomInvivo merged commit 14b45f4 into torchmetrics Sep 20, 2024
3 of 4 checks passed
@DomInvivo DomInvivo mentioned this pull request Sep 23, 2024
28 tasks
@DomInvivo DomInvivo mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants