Remove name reset in CreateItemModal #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1369 +/- ##
=======================================
Coverage 80.10% 80.10%
=======================================
Files 70 70
Lines 4759 4759
=======================================
Hits 3812 3812
Misses 947 947 🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/copied-item_name
|
| Run status |
|
| Run duration | 06m 27s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
217
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/editPage.cy.js • 1 failed test • End-to-end tests (electron)
| Test | Artifacts | |
|---|---|---|
| Edit Page > Clicks the upload buttons and checks that the modals are shown |
Test Replay
Screenshots
|
|
ml-evs
force-pushed
the
bc/copied-item_name
branch
from
b592ac5 to
2910e24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to an issue in #1355
There is some strange behaviour when creating multiple copies of an item (using CreateItemModal) in a row without refreshing the page: As we do not clear the modal between two submit, upon the second creation, most fields are still present (except for id and date, which are cleared).
So if we created an item with the option ‘(Optional) Copy from existing sample:’, it should have the name ‘COPY OF ....’ However, since the name is clear in the modal and is only managed in the front, the second copy will not have a name (unless the user writes one, of course).