Add test for item graph difference between admins and users #1360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/item-graph-admin-test
branch
from
b6640f0 to
f3e6db6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1360 +/- ##
==========================================
+ Coverage 80.05% 80.07% +0.02%
==========================================
Files 70 70
Lines 4737 4737
==========================================
+ Hits 3792 3793 +1
+ Misses 945 944 -1 🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/item-graph-admin-test
|
| Run status |
|
| Run duration | 08m 22s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
336
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
force-pushed
the
ml-evs/item-graph-admin-test
branch
from
d3ef293 to
2ca833a
Compare
BenjaminCharmes
added a commit
that referenced
this pull request
Oct 24, 2025
Re-add old comments Re-add old comments Fix test_graph.py with right numbers of nodes and edges for each test (for items and collections) Add test for item graph difference between admins and users (#1360) Re-add get_graph_cy_format modification Fix pytest Re-add user_only=False Re-add user_only=False
BenjaminCharmes
added a commit
that referenced
this pull request
Oct 27, 2025
Re-add old comments Re-add old comments Fix test_graph.py with right numbers of nodes and edges for each test (for items and collections) Add test for item graph difference between admins and users (#1360) Re-add get_graph_cy_format modification Fix pytest Re-add user_only=False Re-add user_only=False
ml-evs
pushed a commit
that referenced
this pull request
Oct 28, 2025
Re-add old comments Re-add old comments Fix test_graph.py with right numbers of nodes and edges for each test (for items and collections) Add test for item graph difference between admins and users (#1360) Re-add get_graph_cy_format modification Fix pytest Re-add user_only=False Re-add user_only=False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1355, perhaps useful for @BenjaminCharmes. This PR adds a failing test that shows the difference between user and admin views of local item graphs.