Skip to content

clean: lint and format, add pre-commit, update README #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2024
Merged

clean: lint and format, add pre-commit, update README #25

merged 1 commit into from
Sep 20, 2024

Conversation

@bolinocroustibat
Copy link
Contributor

@bolinocroustibat bolinocroustibat commented Sep 18, 2024 •
edited
Loading

Traditional introductive cleaning PR before getting into the repo :)
To align with the other projects, this PR is a proposal that includes:

  • Use Ruff as linter and formatter
  • Remove Flake8 linter
  • Lint and format the code
  • Add a pre-commit hook to lint and format the code
  • Update the CI to check for linting and formatting
  • Update README about how to contribute
  • Update .gitignore

@bolinocroustibat
clean: use ruff for linting and formatting, lint and format the code,…
49c264c 
… update docs, update .gitignore, add a pre-commit hook
@bolinocroustibat bolinocroustibat requested review from Pierlou and maudetes and removed request for Pierlou September 18, 2024 11:49
@bolinocroustibat bolinocroustibat changed the title clean: use ruff for linting and formatting, lint and format the code,… clean: lint and format, add pre-commit, update README Sep 18, 2024
maudetes
maudetes approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahah thank you for the cleaning intro 🧹

@bolinocroustibat bolinocroustibat merged commit 6530796 into main Sep 20, 2024
@bolinocroustibat bolinocroustibat deleted the clean branch September 24, 2024 12:08
@bolinocroustibat bolinocroustibat self-assigned this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maudetes maudetes maudetes approved these changes

@Pierlou Pierlou Awaiting requested review from Pierlou

Assignees

@bolinocroustibat bolinocroustibat

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bolinocroustibat @maudetes