Better swagger and new filters #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffreyaldebert
approved these changes
Aug 8, 2024
tests/test_api.py
Outdated
| "prev": external_url( | ||
| "/api/resources/60963939-6ada-46bc-9a29-b288b16d969b/data/?page=1&page_size=1"), | ||
| "profile": external_url("/api/resources/60963939-6ada-46bc-9a29-b288b16d969b/profile/"), | ||
| "swagger": external_url("/api/resources/60963939-6ada-46bc-9a29-b288b16d969b/swagger/"), |
Contributor
There was a problem hiding this comment.
maybe you can add a specific test for swagger ?
maudetes
approved these changes
Aug 16, 2024
Contributor
maudetes
left a comment
maudetes
left a comment
There was a problem hiding this comment.
I haven't read the entire swagger building logic type by type but seems fair! 🚀
Contributor
There was a problem hiding this comment.
Why did you modify this file?
Contributor
Author
There was a problem hiding this comment.
The previous csv/db that was loaded was not very relavant for the tests, as it was lacking multiple types, so I changed it to be able to test everything properly (and reduced the file's sizes)
maudetes
approved these changes
Aug 30, 2024
Contributor
maudetes
left a comment
maudetes
left a comment
There was a problem hiding this comment.
Nice! I have a minor comment but it seemed to work nicely with real life examples as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully tested with Swagger editor
New filters/operators added, including
in, which fixes datagouv/data.gouv.fr#1408