Skip to content

arrow-pg: panic when encoding dictionary arrays #141

@savani02

Description

@savani02

I noticed that there was a small bug with how the DataType::Dictionary branch retrieves values - at the moment it uses the row index to directly access the dictionary's values array which means that in circumstances where the row index is greater than the length of the dictionary, we hit an out of bounds error.

A quick fix for this could be to access the keys first, get the row index and use that instead to extract values. We could also add a test to just check that this works and hits the happy path.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions