Bump lcp to v0.2.12 #3
Conversation
| .PHONY: fmt | ||
| fmt: | ||
| @cargo fmt --all && cd ./enclave && cargo fmt --all | ||
| @cd ./enclave && cargo fmt --all |
There was a problem hiding this comment.
Since cargo fmt failed on the directory.
$ cargo fmt --all
`cargo metadata` exited with an error: error: could not find `Cargo.toml` in `/home/ubuntu/ghq/github.com/datachainlab/besu-ethereum-ibc-lcp` or any parent directory
| setup_runtime!({ | ||
| Environment::new(build_lc_registry()) | ||
| }); | ||
| setup_runtime!({ Environment::new(build_lc_registry()) }); |
There was a problem hiding this comment.
This change is just formatted by make fmt.
| - --allow-insecure-unlock | ||
| - --unlock=0xa89F47C6b463f74d87572b058427dA0A13ec5425,0xcBED645B1C1a6254f1149Df51d3591c6B3803007 |
There was a problem hiding this comment.
https://github.com/ethereum/go-ethereum/releases/tag/v1.14.12
we cannot use --unlock anymore.
| accounts: { | ||
| mnemonic: "math razor capable expose worth grape metal sunset metal sudden usage scheme", | ||
| path: "m/44'/60'/0'/0", | ||
| initialIndex: 0, | ||
| count: 1, | ||
| passphrase: "", | ||
| } |
There was a problem hiding this comment.
| module.exports = { | ||
| solidity: { | ||
| version: "0.8.20", | ||
| version: "0.8.28", |
There was a problem hiding this comment.
TODO: try to add cancun to Besu-side as well
There was a problem hiding this comment.
Since cancun isn't enabled in genesis.json, it's okay not to enable cancun on Besu-side.
https://github.com/datachainlab/besu-ethereum-ibc-lcp/blob/main/tests/e2e/chains/besu/chain/qbftConfigFile.json
| }, | ||
| "minimal_fork_sched": { | ||
| "electra": 82125 |
There was a problem hiding this comment.
| @@ -1,23 +1,21 @@ | |||
| module github.com/datachainlab/cosmos-ethereum-ibc-lcp | |||
| module github.com/datachainlab/besu-ethereum-ibc-lcp | |||
bluele
left a comment
bluele
left a comment
There was a problem hiding this comment.
@junichi-tanaka Sorry for the late review🙇 LGTM👍
Uh oh!
There was an error while loading. Please reload this page.