Fix: escape and truncate default query tag values #1273
+131
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
reviewed
Nov 25, 2025
dbt/adapters/databricks/utils.py
Outdated
| escaped_value = QueryTagsUtils.escape_tag_value(key, value, "Default tags") | ||
|
|
||
| if len(escaped_value) > 128: | ||
| logger.warning( |
Collaborator
There was a problem hiding this comment.
I'm not sure we want to emit a warning, because this is not something the user can really take action on. Maybe just debug?
benc-db
previously approved these changes
Nov 25, 2025
Collaborator
benc-db
left a comment
benc-db
left a comment
There was a problem hiding this comment.
Approve with minor comment.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
ericj-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
ericj-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Description
Fix to ensure that default (i.e. auto) query tag values are not invalid
Tested using a model with name
accepted_values_backhaulcontractschedule_site_category_3__Non_Served_Sites__New_Sites__Served_Sites__Non_HS_Sites__Served_Site__CHARACTERS_BEYOND_128Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.