-
Notifications
You must be signed in to change notification settings - Fork 9
[dependency] Upgrade Material UI to v.7 #1944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ccdc2cb to
5585e85
Compare
f336927 to
d61a578
Compare
5585e85 to
795f528
Compare
d61a578 to
054ab61
Compare
795f528 to
14c63b1
Compare
054ab61 to
23c00a8
Compare
14c63b1 to
604c7fb
Compare
23c00a8 to
2ba9a46
Compare
45d85c2 to
a6b4a08
Compare
modules/data-entry/src/main/frontend/src/dataHomepage/LiveTable.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/dataHomepage/SubjectView.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/questionnaire/DicomQuestion.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/questionnaire/FileQuestion.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/questionnaire/PedigreeQuestion.jsx
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/questionnaire/Questionnaire.jsx
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/questionnaire/SubjectSelector.jsx
Outdated
Show resolved
Hide resolved
modules/patient-portal/src/main/frontend/src/patient-portal/LandingPage.jsx
Outdated
Show resolved
Hide resolved
modules/homepage/src/main/frontend/src/themePage/Navbars/AdminNavbarLinks.jsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a future PR, since MUI is moving from individual somethingProps to slotProps, we should also change the way we pass component props between our component to something similar, for example here we have textFieldProps, and in AdminResourceListing we have buttonProps.
|
In general as we are developing the app for the users we should prioritise the usability over our personal preferences of any points. As far as I understand the goal, it is not what we personally like or aesthetically prefer is important but what is comfortable for the end user group and brings an effective and productive clear user experience in a first place. If we focus on the most effective workflow of filling the questionnaires, the text presentation is playing the center role here. The spacing, the alignment and decorations all are the equally influetial on user-computer interaction effectiveness. There was a research conducted to stydy how text alignment is affecting the content disgesting and impacts how the brain processes information visually and cognitively for the production of web pages. This study highlights the importance of prioritizing readability over pure aesthetics in text alignment. The spoiler is that left-aligned body text led to better performance, although participants preferred justified text. Anything text-centered which is more than 3 lines will create additional load of eye movement, brain processing and extra hardness to follow. When centering could be an excellent tool for placing short call-for-attension elements to emphacize, like a link/action button, shourt quote, or navigate, like topic headings, it is not favourable to use centering for listing numerous user instructions or presenting introduction texts. Those are usual common design priciples of web presentations as I see them in current. |
And that is why I suggested to create a separate task to improve the layout. This is about upgrading a dependency and should remain focused on its purpose. |
Co-authored-by: Sergiu Dumitriu <[email protected]>
More slotProps applications to previous v.5 props handling way
Total support :) |
…layed in the wrong place
…layed in the wrong place Better Snackbar positioning Co-authored-by: Marta Girdea <[email protected]>
CARDS-2671: After changing the password, a confirmation alert is displayed in the wrong place
sdumitriu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get this error when first displaying some of the tables:
There was a problem inserting the following rule: ".tss-gur5lp-MuiTablePagination-root . MuiTablePagination-select{margin:0 1px;}" DOMException: An invalid or illegal string was specified
I think it's not from our code, but a bug in MuiTable? To trigger it, start adding a new Questionnaire from the dashboard, it shows as soon as the list of questionnaires is loaded, or go to Administration -> Questionnaires, Users, Clinics or other pages with a table.
modules/downtime-warning-banner/src/main/frontend/src/downtimeBanner.jsx
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/questionnaire/QuestionnairePreview.jsx
Outdated
Show resolved
Hide resolved
| ['cards-homepage.modelOrganismsIcon']: '@mui/icons-material/Pets' | ||
| ['cards-homepage.variantsIcon']: '@mui/icons-material/Subtitles' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 aren't even used, they should be removed in a separate PR.
modules/homepage/src/main/frontend/src/themePage/Navbars/AdminNavbarLinks.jsx
Show resolved
Hide resolved
modules/patient-portal/src/main/frontend/src/patient-portal/QuestionnaireSet.jsx
Show resolved
Hide resolved
Align top right naviagtion/avatar icon to the right top side; Removed unused styling class
Align quick result search with the search input width, remove extra padding
Revert changes for QuestionnairePreview Grid
Fixed demo banner and downtime warning icon grid min width
modules/homepage/src/main/frontend/src/themePage/Sidebar/sidebarStyle.jsx
Outdated
Show resolved
Hide resolved
Better alignment for the avatar
Better alignment for the drawer toggle button
Improve alignment of the navbar and the content
Removed required classes prop from DateQuestionYear propTypes

Updated dependencies:
@mui/x-date-pickers@mui/lab@mui/icons-material@mui/materialjss->tss-reactRemoved deprecated dependency:
@mui/stylesManuals used:
https://mui.com/material-ui/migration/upgrade-to-v6/
https://mui.com/material-ui/migration/migrating-from-deprecated-apis
https://mui.com/material-ui/migration/upgrade-to-v7/
https://mui.com/material-ui/migration/migrating-from-jss/
https://mui.com/x/migration/migration-data-grid-v6/