Skip to content

Add complex number support to sin #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2022
Merged

Add complex number support to sin #457

merged 2 commits into from
Jul 7, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Jun 20, 2022

This PR

  • adds complex number support to sin by documenting special cases. The sine is an entire function in the complex plane. Thus, the function has no branch cuts.
  • updates the input and output array data types to be any floating-point data type, not just real-valued floating-point data types.
  • derives special cases from C99.

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Jun 20, 2022
@kgryte kgryte added this to the v2022 milestone Jun 20, 2022
@kgryte kgryte mentioned this pull request Jun 20, 2022
Closed
@kgryte
Copy link
Contributor Author

kgryte commented Jul 7, 2022

As sin does not involve branch cuts and the special cases introduced in this PR rely on sinh and follow prior art, will merge. Further revisions can be addressed in subsequent PRs...

@kgryte kgryte merged commit 3c7395c into main Jul 7, 2022
@kgryte kgryte deleted the cmplx-sin branch July 7, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.
1 participant
@kgryte