fix(drive): add path query back to GroveDBError

[pauldelucia]

Issue being fixed or feature implemented

GroveDBError used to return path query, which DET's proof logs page needs

What was done?

Add optional path query back to GroveDBError, update GroveDB dependency

How Has This Been Tested?

Existing CI

Breaking Changes

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• New Features
  • Enhanced error messages for database errors to include additional query information.
• Chores
  • Updated dependency revisions for GroveDB-related crates to the latest commit across multiple packages.

[coderabbitai]

Warning

Rate limit exceeded

@pauldelucia has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 10 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c741d27 and 6e1e111.

📒 Files selected for processing (1)

• packages/rs-drive-proof-verifier/src/proof.rs (2 hunks)

Walkthrough

The changes extend the GroveDBError variant of the Error enum in the rs-drive-proof-verifier package by adding a new optional path_query field of type Option<PathQuery>. The error mapping logic is updated so that when a drive::error::Error::GroveDB is converted, the path_query field is populated from the InvalidProof variant’s path_query if present. The PathQuery type is imported from drive::query. Additionally, the Git revision hashes for multiple grovedb-related dependencies were updated in the Cargo.toml files of the rs-drive and platform-version packages. No other modifications to error handling or control flow were introduced.

Changes

File(s)	Change Summary
packages/rs-drive-proof-verifier/src/error.rs	Added optional field path_query: Option<PathQuery> to Error::GroveDBError and updated error mapping logic.
packages/rs-drive-proof-verifier/src/proof.rs	Enhanced error handling to extract and include path_query from InvalidProof GroveDB errors in proof conversions.
packages/rs-drive/Cargo.toml	Updated Git revision hashes for all grovedb-related dependencies to a new commit hash.
packages/rs-platform-version/Cargo.toml	Updated Git revision hash for the grovedb-version dependency to a new commit hash.

Possibly related PRs

• feat(sdk): including grovedb proof bytes when error in proof verification #2332: Both PRs modify the GroveDBError variant in the same error enum, but with different fields and error handling enhancements for GroveDB errors.

Suggested reviewers

• QuantumExplorer
• shumkov

Poem

In the warren where errors leap and bound,
A new path is queried, a solution is found.
With fields extended, our enum grows,
Mapping the proof as the database flows.
🐇✨
Now GroveDB errors are clearer to see—
More paths for the code, and for you and for me!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/rs-drive-proof-verifier/src/error.rs (1)

148-163: Consider adding tests for this change

The change looks good, but consider adding tests to verify that the path_query field is correctly populated when converting from drive::error::Error::GroveDB to Error::GroveDBError.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db1fcb8 and 922c0f7.

📒 Files selected for processing (1)

• packages/rs-drive-proof-verifier/src/error.rs (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: Rust packages (dash-sdk) / Check each feature
• GitHub Check: Rust packages (dash-sdk) / Unused dependencies
• GitHub Check: Rust packages (dash-sdk) / Tests
• GitHub Check: Rust packages (dash-sdk) / Linting
• GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
• GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
• GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
• GitHub Check: Build JS packages / Build JS

🔇 Additional comments (3)

packages/rs-drive-proof-verifier/src/error.rs (3)

3-3: LGTM: Added import for PathQuery

The import of PathQuery from drive::query is necessary for the added field in the GroveDBError variant.

---

24-24: LGTM: Added path_query field to GroveDBError

This change aligns with the PR objectives to restore the path query to the GroveDBError, which is required by the DET's proof logs page.

---

154-154: LGTM: Properly populating path_query field

The implementation correctly sets the path_query field by cloning the value from the proof object when mapping a drive::error::Error::GroveDB to Error::GroveDBError.