Skip to content

fix(dashmate): status command fails if drive is not running #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix(dashmate): status command fails if drive is not running #2364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
873210d
fix(dashmate): status command fails if drive is not running
shumkov Dec 2, 2024
01ace99
Merge branch 'master' into fix/dashmate/fix-status-drive-is-not-respo…
shumkov Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/dashmate/src/status/scopes/platform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { DockerStatusEnum } from '../enums/dockerStatus.js';
import { ServiceStatusEnum } from '../enums/serviceStatus.js';
import determineStatus from '../determineStatus.js';
import ContainerIsNotPresentError from '../../docker/errors/ContainerIsNotPresentError.js';
import ServiceIsNotRunningError from '../../docker/errors/ServiceIsNotRunningError.js';

/**
* @returns {getPlatformScopeFactory}
Expand Down Expand Up @@ -218,7 +219,8 @@ export default function getPlatformScopeFactory(
// Throw an error if it's not a Drive issue
if (!(e instanceof DockerComposeError
&& e.dockerComposeExecutionResult
&& e.dockerComposeExecutionResult.exitCode !== 0)) {
&& e.dockerComposeExecutionResult.exitCode !== 0)
&& !(e instanceof ServiceIsNotRunningError)) {
throw e;
}
}
Expand Down
Loading