-
Notifications
You must be signed in to change notification settings - Fork 44
build: devcontainer support #2179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0d7317d
build: devcontainer support
shumkov 97974b1
chore: update plugins and create scripts
shumkov 63b5fca
chore: update plugins and docker file
shumkov 147e921
build: fix cargo and git
shumkov cda6e3b
build: fix docker
shumkov f6cecda
build: persist rust cache
shumkov bad1bfe
build: persist more granular cache
shumkov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Use the official VS Code base image for dev containers | ||
| FROM mcr.microsoft.com/devcontainers/rust:1-1-bullseye | ||
|
|
||
| # Install dependencies | ||
| RUN apt-get update && apt-get install -y \ | ||
| build-essential \ | ||
| libssl-dev \ | ||
| pkg-config \ | ||
| clang \ | ||
| cmake \ | ||
| llvm \ | ||
| curl \ | ||
| gnupg \ | ||
| lsb-release \ | ||
| software-properties-common \ | ||
| unzip | ||
|
|
||
| # Install protoc v25.2+ | ||
| RUN curl -OL https://github.com/protocolbuffers/protobuf/releases/download/v25.2/protoc-25.2-linux-x86_64.zip \ | ||
| && unzip protoc-25.2-linux-x86_64.zip -d /usr/local \ | ||
| && rm protoc-25.2-linux-x86_64.zip | ||
|
|
||
| # Install [email protected] | ||
| RUN cargo install [email protected] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "name": "Dash Platform Dev Container", | ||
| "build": { | ||
| "dockerfile": "Dockerfile", | ||
| "context": ".." | ||
| }, | ||
| "customizations": { | ||
| "vscode": { | ||
| "settings": {}, | ||
| "extensions": [ | ||
| "ms-vscode.cpptools", | ||
| "ms-vscode.cmake-tools", | ||
| "dbaeumer.vscode-eslint", | ||
| "esbenp.prettier-vscode", | ||
| "vadimcn.vscode-lldb", | ||
| "rust-lang.rust-analyzer", | ||
| "tamasfe.even-better-toml", | ||
| ] | ||
| } | ||
| }, | ||
| "remoteUser": "vscode", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/git:1": {}, | ||
| "ghcr.io/devcontainers/features/github-cli:1": {}, | ||
| "ghcr.io/devcontainers/features/rust:1": { | ||
| "version": 1.80, | ||
| "targets": "wasm32-unknown-unknown", | ||
| }, | ||
| "ghcr.io/devcontainers/features/node:1": { | ||
| "version": 20, | ||
| "installYarnUsingApt": false, | ||
| }, | ||
| "ghcr.io/eitsupi/devcontainer-features/jq-likes:2": {}, | ||
| "ghcr.io/devcontainers/features/docker-outside-of-docker:1": {} | ||
| }, | ||
| "postCreateCommand": "cargo install [email protected]" | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Update
wasm-bindgen-clito the latest version (0.2.93)The current
postCreateCommandinstalls[email protected], while the latest available version is0.2.93. Updating to the latest version can provide important bug fixes and improvements.0.2.93unless there are specific compatibility reasons to remain on0.2.85.🔗 Analysis chain
Verify if pinning wasm-bindgen-cli version is necessary.
Installing wasm-bindgen-cli is appropriate given the WebAssembly target in the Rust configuration. However, the version is pinned to 0.2.85.
Consider if this specific version is required for compatibility reasons. If not, you might want to allow for newer versions to benefit from bug fixes and improvements.
To check the latest version of wasm-bindgen-cli, you can run:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 169
Script:
Length of output: 92