fix: revert deployment images back to Ubuntu 22.04 LTS (jammy), pin QEMU to avoid segfault
#6586
Conversation
|
Special thanks to @ktechmidas for bringing this to attention! |
WalkthroughThe changes update configurations in both the GitHub Actions workflow and multiple Docker deployment files. The GitHub Actions workflow now specifies 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🪛 actionlint (1.7.4).github/workflows/release_docker_hub.yml13-13: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue (action) ⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
contrib/containers/deploy/Dockerfile.GitHubActions.Release (1)
12-17: Enhanced User and Group Setup
The updated section for user creation now sets default environment variables forUSER_IDandGROUP_IDand usesgroupaddanduseraddto create thedashuser. This method is cleaner than modifying an existing user.Nitpick: For consistency with the other Dockerfile, consider quoting the default assignments. For example, change:
-ENV USER_ID ${USER_ID:-1000} -ENV GROUP_ID ${GROUP_ID:-1000} +ENV USER_ID "${USER_ID:-1000}" +ENV GROUP_ID "${GROUP_ID:-1000}"This ensures uniformity across Dockerfiles.
contrib/containers/deploy/Dockerfile.GitHubActions.Dispatch (1)
55-61: Consistent User Creation in Final Stage
The final stage now creates thedashuser with explicit environment variables and usesgroupaddanduseraddto set up the user account and home directory. This change mirrors the updates in the other Dockerfiles.Optional Improvement: For consistency with the
contrib/containers/deploy/Dockerfile, consider quoting theUSER_IDandGROUP_IDdefault values (e.g.,ENV USER_ID="${USER_ID:-1000}").
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/release_docker_hub.yml(1 hunks)contrib/containers/deploy/Dockerfile(1 hunks)contrib/containers/deploy/Dockerfile.GitHubActions.Dispatch(3 hunks)contrib/containers/deploy/Dockerfile.GitHubActions.Release(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/release_docker_hub.yml
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build container / Build container
🔇 Additional comments (7)
contrib/containers/deploy/Dockerfile (5)
1-1: Updated Base Image to Jammy
The base image has been updated fromphusion/baseimage:noble-1.0.0tophusion/baseimage:jammy-1.0.4, which aligns with the PR objective to revert deployment images. Ensure that any dependent configuration or testing environments have been verified for compatibility with the new base image.
5-6: Streamlined ARG Declarations
TheARG USER_IDandARG GROUP_IDdeclarations have been simplified by removing inline defaults; the default behavior is now managed later via environment variable assignments. This approach improves flexibility.
8-9: Explicit HOME Environment Variable
The addition ofENV HOME="/home/dash"explicitly sets the home directory for the new user, which is important for consistency across container operations.
11-12: Defining Default Values for USER_ID and GROUP_ID
The environment variablesUSER_IDandGROUP_IDare now set with fallback defaults ("${USER_ID:-1000}"and"${GROUP_ID:-1000}"), ensuring that even if the build arguments are not supplied, they assume suitable defaults.
13-15: Revised User Creation Process
TheRUNcommand now creates a new groupdashand a new userdashusinggroupaddanduseradd, and also sets up the home directory structure. This explicit user management is clearer and more robust than modifying an existing user.contrib/containers/deploy/Dockerfile.GitHubActions.Release (1)
1-1: Base Image Updated to Ubuntu Jammy
The base image has been updated fromubuntu:nobletoubuntu:jammy, which is consistent with the overall update strategy across the files.contrib/containers/deploy/Dockerfile.GitHubActions.Dispatch (1)
3-3: Builder Stage Base Image Update
The builder stage now usesFROM --platform=$BUILDPLATFORM ubuntu:jammy as builder, which standardizes the build environment with the updated Ubuntu Jammy image.
kwvg
changed the title
jammy)jammy), pin QEMU to avoid segfault
…md64 separately 757b95b ci: attempt to fix docker builds by building arm64 and amd64 separately (pasta) Pull request description: ## Issue being fixed or feature implemented this is a follow-up to #6586; because that fix did not appear to work https://github.com/dashpay/dash/actions/runs/13376032021/job/37424076219 ## What was done? Stop using qemu, and build on arm runners ## How Has This Been Tested? Hasn't; to be tested once merged ## Breaking Changes Can't break which is broken ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: d3516c10c80f4fb6c9db61f7286247002faff9fc095212b19db805d6641760f38db441c57ace3f72bd6a6a5e0af3311987062d1cf8da2803393231748776a4bb
…4 LTS (`jammy`), pin QEMU to avoid segfault 20524e4 fix: pin version of QEMU to avoid segfault (Kittywhiskers Van Gogh) c8ab705 revert: update containers and CI to use Ubuntu 24.04 LTS (`noble`) (Kittywhiskers Van Gogh) 2bcc90a revert: use default non-root user `ubuntu` introduced in Ubuntu 22.10 (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * There is a regression in `noble` that has caused a build failure in trying to package our release container ([build](https://github.com/dashpay/dash/actions/runs/13376032021)) linked to [docker/setup-qemu-action#198](docker/setup-qemu-action#198). * In light of this, all non-CI containers and jobs have been moved back to Ubuntu 22.04 (`jammy`) though it seems that downgrading alone may be insufficient (see [actions/runner-images#11471](actions/runner-images#11471 (comment))). * To remedy this we are pinning the version of QEMU as suggested in [tonistiigi/binfmt#240](tonistiigi/binfmt#240 (comment)) ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 20524e4 Tree-SHA512: 26bb2cd55a0267b56f86938d97ddfa32f0cdd8a2786c0366eedbcddf706e38b6af93cd29ab98ba420cbdbd112561ded61e2dba906c4b233ad737f24730f58ddc
…4 LTS (`jammy`), pin QEMU to avoid segfault 20524e4 fix: pin version of QEMU to avoid segfault (Kittywhiskers Van Gogh) c8ab705 revert: update containers and CI to use Ubuntu 24.04 LTS (`noble`) (Kittywhiskers Van Gogh) 2bcc90a revert: use default non-root user `ubuntu` introduced in Ubuntu 22.10 (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * There is a regression in `noble` that has caused a build failure in trying to package our release container ([build](https://github.com/dashpay/dash/actions/runs/13376032021)) linked to [docker/setup-qemu-action#198](docker/setup-qemu-action#198). * In light of this, all non-CI containers and jobs have been moved back to Ubuntu 22.04 (`jammy`) though it seems that downgrading alone may be insufficient (see [actions/runner-images#11471](actions/runner-images#11471 (comment))). * To remedy this we are pinning the version of QEMU as suggested in [tonistiigi/binfmt#240](tonistiigi/binfmt#240 (comment)) ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 20524e4 Tree-SHA512: 26bb2cd55a0267b56f86938d97ddfa32f0cdd8a2786c0366eedbcddf706e38b6af93cd29ab98ba420cbdbd112561ded61e2dba906c4b233ad737f24730f58ddc
8b4ab03 fix: suppress MIN_MASTERNODE_PROTO_VERSION bump in 6608 (pasta) aca04d1 chore: bump build to 22.1.2 (pasta) d9d8c24 docs: add release notes for 22.1.2 (pasta) fb45240 Merge #6608: fix: `cycleHash` should represent a cycle starting block of the signing quorum (pasta) 9d1498c Merge #6625: fix: adjust quorum rotation data results in some edge cases, add tests (pasta) dfc1119 Merge #6622: fix: efficient build mnlistdiffs in rotation info (pasta) 6fd626b Merge #6586: fix: revert deployment images back to Ubuntu 22.04 LTS (`jammy`), pin QEMU to avoid segfault (pasta) affa9d1 Merge #6599: fix: follow-up #6546 to bump copyright year in COPYING and debian's package (pasta) f6163a2 Merge #6593: fix: resolve potential deadlock in coinjoin_tests (pasta) 243e0ab Merge #6585: fix: Do not assert special tx type for cbtx in simplified mn list diff output (pasta) 497f95c Merge #6581: perf: speedup of CBLSLazyPublicKey::operator== when comparing to the default / null object; speedup CDeterministicMNList::AddMN by avoiding check to IsValid when a nullcheck is sufficient (pasta) Pull request description: ## Issue being fixed or feature implemented Backports for a new version, v22.1.2 ## What was done? See release notes ## How Has This Been Tested? ## Breaking Changes None ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 8b4ab03 knst: utACK 8b4ab03 Tree-SHA512: 9f2f65e315940197cc2b75a6b0a858d624256cbe668272ff6dfa216eceda1ba9338484d47afc569202b3b5cc75b4dcb825209efe3a3d3ccec57c741f75c40577
8b4ab03 fix: suppress MIN_MASTERNODE_PROTO_VERSION bump in 6608 (pasta) aca04d1 chore: bump build to 22.1.2 (pasta) d9d8c24 docs: add release notes for 22.1.2 (pasta) fb45240 Merge #6608: fix: `cycleHash` should represent a cycle starting block of the signing quorum (pasta) 9d1498c Merge #6625: fix: adjust quorum rotation data results in some edge cases, add tests (pasta) dfc1119 Merge #6622: fix: efficient build mnlistdiffs in rotation info (pasta) 6fd626b Merge #6586: fix: revert deployment images back to Ubuntu 22.04 LTS (`jammy`), pin QEMU to avoid segfault (pasta) affa9d1 Merge #6599: fix: follow-up #6546 to bump copyright year in COPYING and debian's package (pasta) f6163a2 Merge #6593: fix: resolve potential deadlock in coinjoin_tests (pasta) 243e0ab Merge #6585: fix: Do not assert special tx type for cbtx in simplified mn list diff output (pasta) 497f95c Merge #6581: perf: speedup of CBLSLazyPublicKey::operator== when comparing to the default / null object; speedup CDeterministicMNList::AddMN by avoiding check to IsValid when a nullcheck is sufficient (pasta) 4298d73 chore: bump to 22.1.1 (pasta) fc65a16 chore: release notes for 22.1.1 (pasta) 38762f7 Merge #6574: fix: ReconnectionInfo should also store Dash-specific flags (pasta) 580b74c Merge #6566: fix(qt): avoid leaking balance and CJ info in GUI when in discreet mode (pasta) Pull request description: ## Issue being fixed or feature implemented ## What was done? ff-ed `master` 21.1.0 -> 21.1.2, merging it back into `develop` now ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 73fa780; gonna merge as this changes docs only Tree-SHA512: f04fe461edc05c38771d684bd5d60327076251b8004723027276b104989ea6d84f7f77cce31f310f058e81f2c25411ab5a15b563cd3db66091ccaf33da459e3c
4 participants
Additional Information
There is a regression in
noblethat has caused a build failure in trying to package our release container (build) linked to docker/setup-qemu-action#198.In light of this, all non-CI containers and jobs have been moved back to Ubuntu 22.04 (
jammy) though it seems that downgrading alone may be insufficient (see actions/runner-images#11471).Checklist: