Skip to content

Conversation

@knst
Copy link
Collaborator

@knst knst commented Jun 17, 2024

Issue being fixed or feature implemented

There're some usages of unique pointers in RPC code that are not guarded by non-nullptr checks

What was done?

Added missing CHECK_NON_FATAL and refactored some of them to EnsureConnman and EnsurePeerman

How Has This Been Tested?

Run unit/functional tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 21 milestone Jun 17, 2024
@knst knst requested review from PastaPastaPasta and UdjinM6 June 17, 2024 17:10
@knst knst force-pushed the fix-missing-checks-rpc-nullptr branch from ee7ff64 to dc15420 Compare June 17, 2024 17:41
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK dc15420

@PastaPastaPasta PastaPastaPasta merged commit 6cb8dcd into dashpay:develop Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants