Skip to content

Bump remaining min protocols #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2018
Merged

Bump remaining min protocols #2097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18cbd20
bump MIN_GOVERNANCE_PEER_PROTO_VERSION
UdjinM6 May 30, 2018
757af57
bump MIN_MASTERNODE_PAYMENT_PROTO_VERSION_2
UdjinM6 Jun 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/governance-object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class CGovernanceObject;
class CGovernanceVote;

static const int MAX_GOVERNANCE_OBJECT_DATA_SIZE = 16 * 1024;
static const int MIN_GOVERNANCE_PEER_PROTO_VERSION = 70206;
static const int MIN_GOVERNANCE_PEER_PROTO_VERSION = 70208;
static const int GOVERNANCE_FILTER_PROTO_VERSION = 70206;

static const double GOVERNANCE_FILTER_FP_RATE = 0.001;
Expand Down
2 changes: 1 addition & 1 deletion src/masternode-payments.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ static const int MNPAYMENTS_SIGNATURES_TOTAL = 10;
// V1 - Last protocol version before update
// V2 - Newest protocol version
static const int MIN_MASTERNODE_PAYMENT_PROTO_VERSION_1 = 70206;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this also be bumped to 70208?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's how we did this in the past and why it says V1 - Last protocol version before update BUT I was thinking about it a bit more and it seems to me that we probably should NOT bump this in the time of major migration to have the same base with old nodes when spork10 is off and instead we should bump it in a minor pre-major update (if at all, maybe we could just leave it static forever?).

static const int MIN_MASTERNODE_PAYMENT_PROTO_VERSION_2 = 70208;
static const int MIN_MASTERNODE_PAYMENT_PROTO_VERSION_2 = 70209;

extern CCriticalSection cs_vecPayees;
extern CCriticalSection cs_mapMasternodeBlocks;
Expand Down