Add docker support when doing Gitian builds #2084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just verified that the builds produced by the Docker version are binary identical to the builds produced by the LXC (inside a VM) builds. They are however only identical when you use the same gitian-builder version, so it's not easily possible to verify that older releases of Dash result in the same build when using the latest gitian-builder version. But I assume this is expected. |
Requires a gitian-builder version with devrandom/gitian-builder#181 This will also switch to use Docker by default.
codablock
force-pushed
the
pr_gitian_docker
branch
from
e2232a4 to
430156e
Compare
|
To allow merging this PR before gitian-builder has the necessary PR merged, I changed the default back to --lxc. When gitian-builder is ready, I'll create another PR to change the default to --docker |
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
* gitian-build.sh: fix signProg being recognized as two parameters * Support docker based Gitian builds Requires a gitian-builder version with devrandom/gitian-builder#181 This will also switch to use Docker by default. * Switch back to using lxc as default until upstream gitian-builder is ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a gitian-builder version with devrandom/gitian-builder#181
When this is merged into the upstream gitian-builder, I'll create a PR into our fork. Until then, I'd suggest to directly clone the upstream version and fetch the pull request manually:
This PR also includes a backported commit to fix an issue with gpg invocation.