Update gitian keys, script and doc #2082
Conversation
gitian-building.md referenced "br0" but "lxcbr0" was used in the script. gitian-build.sh used 10.0.2.2 as IP for the bridge but this conflicts with VirtualBox networking.
|
utACK 04f2e39 |
|
What's the motivation behind this, what will this allow you to do? Thanks. |
|
@paulied It never made sense to have the Gitian keys of Bitcoin developers inside the Dash repo. Also, we're currently considering changing the way we do releases (introduce proper Gitian signing by our devs). |
contrib/gitian-keys/nmarley.pgp
Outdated
| IWdiYNzA1p3M3QNrTfMvRCTl80LMQBLhfhzQkDM9JldjGUzMkWpX8awJLEYNmOL2 | ||
| On0zI0oMYOhBYYNELJM+4GPqNBWH8NjwZ8/ujz6H30ISyh4KwP0oh4bnvVw= | ||
| =X22E | ||
| -----END PGP PUBLIC KEY BLOCK----- No newline at end of file |
contrib/gitian-keys/schinzelh.pgp
Outdated
| mhR5sfgrZHXchFBrPv3Gqzy8CZV4N66RTDTObxEb5R5bMt+NMO713f6quEOMStbb | ||
| R/tLzA== | ||
| =CeyW | ||
| -----END PGP PUBLIC KEY BLOCK----- No newline at end of file |
|
utACK 0ca36bb w/EOL char added, couple small nits (files without terminating newline drive me nuts, and this is a POSIX standard) |
There was a problem hiding this comment.
Although it looks good, and I'll approve it for the sake of it. What is the state of 12.3? I thought the freeze was in effect a while ago, yet I keep seeing more commits being marked as being for 12.3, why is this and others being added to 12.3? Would like to understand why, thanks!
|
@paulied Our usual release process involves Gitian binaries built with Bamboo, which are then used for tests on testnet. Bamboo is down however and we're struggling making it run again, so we must consider alternatives to using Bamboo for this. Not just for now, but for the future as well. Establishing new keys from Dash developers is one step in this, the next step will be to either manually create signed release binaries and/or setup a new CI environment. We are doing this kind of in parallel now and whatever is finished first might be used for the release. |
|
Thank you @codablock. For future problems which delay launch, and even this one, I would really appreciate a public update, nothing fancy something just like "We are having a problem with our traditional release flow and are trying to improve it for the future. We hope to have it fixed in a week or two. Sorry for the delay." Something like that would really make the community feel better about any delays based on my talking with people. Thanks for the great work, though! |
* Remove Bitcoin Gitian keys * Update gitian-build.sh and gitian-building.md gitian-building.md referenced "br0" but "lxcbr0" was used in the script. gitian-build.sh used 10.0.2.2 as IP for the bridge but this conflicts with VirtualBox networking. * Add gitian key for codablock https://keybase.io/codablock * Add gitian key for schinzelh https://keybase.io/schinzelh * Add gitian key for gladcow https://keybase.io/gladcow * Add gitian key for nmarley https://keybase.io/nmarley * Add gitian key for udjinm6 https://keybase.io/UdjinM6 * Add EOL chars
* Remove Bitcoin Gitian keys * Update gitian-build.sh and gitian-building.md gitian-building.md referenced "br0" but "lxcbr0" was used in the script. gitian-build.sh used 10.0.2.2 as IP for the bridge but this conflicts with VirtualBox networking. * Add gitian key for codablock https://keybase.io/codablock * Add gitian key for schinzelh https://keybase.io/schinzelh * Add gitian key for gladcow https://keybase.io/gladcow * Add gitian key for nmarley https://keybase.io/nmarley * Add gitian key for udjinm6 https://keybase.io/UdjinM6 * Add EOL chars
5 participants
See individual commits