Skip to content

feat: retry vote poll end times query and insert proof logs #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2024
Merged

feat: retry vote poll end times query and insert proof logs #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8e723c
feat: retry vote poll end times query
pauldelucia Nov 20, 2024
621fa35
fix logging
pauldelucia Nov 20, 2024
dfa7d80
add proof log to vote contenders query
pauldelucia Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 54 additions & 3 deletions src/backend_task/contested_names/query_dpns_vote_contenders.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use crate::app::TaskResult;
use crate::context::AppContext;
use crate::model::proof_log_item::{ProofLogItem, RequestType};
use dash_sdk::dpp::data_contract::accessors::v0::DataContractV0Getters;
use dash_sdk::dpp::data_contract::document_type::accessors::DocumentTypeV0Getters;
use dash_sdk::dpp::platform_value::Value;
Expand Down Expand Up @@ -59,7 +60,57 @@ impl AppContext {
.map_err(|e| e.to_string());
}
Err(e) => {
tracing::error!("Error fetching contested resources: {}", e);
tracing::error!("Error fetching vote contenders: {}", e);
if let dash_sdk::Error::Proof(
dash_sdk::ProofVerifierError::GroveDBProofVerificationError {
proof_bytes,
path_query,
height,
time_ms,
error,
},
) = &e
{
// Encode the query using bincode
let encoded_query = match bincode::encode_to_vec(
&contenders_query,
bincode::config::standard(),
)
.map_err(|encode_err| {
tracing::error!("Error encoding query: {}", encode_err);
format!("Error encoding query: {}", encode_err)
}) {
Ok(encoded_query) => encoded_query,
Err(e) => return Err(e),
};

// Encode the path_query using bincode
let verification_path_query_bytes =
match bincode::encode_to_vec(&path_query, bincode::config::standard())
.map_err(|encode_err| {
tracing::error!("Error encoding path_query: {}", encode_err);
format!("Error encoding path_query: {}", encode_err)
}) {
Ok(encoded_path_query) => encoded_path_query,
Err(e) => return Err(e),
};

if let Err(e) = self
.db
.insert_proof_log_item(ProofLogItem {
request_type: RequestType::GetContestedResourceIdentityVotes,
request_bytes: encoded_query,
verification_path_query_bytes,
height: *height,
time_ms: *time_ms,
proof_bytes: proof_bytes.clone(),
error: Some(error.clone()),
})
.map_err(|e| e.to_string())
{
return Err(e);
}
}
let error_str = e.to_string();
if error_str.contains("try another server")
|| error_str.contains(
Expand All @@ -73,15 +124,15 @@ impl AppContext {
e
);
return Err(format!(
"Error fetching contested resources after retries: {}",
"Error fetching vote contenders after retries: {}",
e
));
} else {
continue;
}
} else {
// For other errors, return immediately
return Err(format!("Error fetching contested resources: {}", e));
return Err(format!("Error fetching vote contenders: {}", e));
}
}
}
Expand Down
136 changes: 106 additions & 30 deletions src/backend_task/contested_names/query_ending_times.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use crate::context::AppContext;
use crate::model::proof_log_item::{ProofLogItem, RequestType};
use chrono::{DateTime, Duration, Utc};
use dash_sdk::dpp::data_contract::accessors::v0::DataContractV0Getters;
use dash_sdk::dpp::voting::vote_polls::contested_document_resource_vote_poll::ContestedDocumentResourceVotePoll;
Expand Down Expand Up @@ -32,43 +33,118 @@ impl AppContext {
order_ascending: true,
};

const MAX_RETRIES: usize = 3;
let mut retries = 0;

let mut contests_end_times = BTreeMap::new();

for (timestamp, vote_poll) in VotePoll::fetch_many(&sdk, end_time_query)
.await
.map_err(|e| format!("error querying vote poll end times: {}", e))?
{
let contests = vote_poll.into_iter().filter_map(|vote_poll| {
let VotePoll::ContestedDocumentResourceVotePoll(
ContestedDocumentResourceVotePoll {
contract_id,
document_type_name,
index_name,
index_values,
},
) = vote_poll;
if contract_id != self.dpns_contract.id() {
return None;
}
if document_type_name != "domain" {
return None;
}
if index_name != "parentNameAndLabel" {
return None;
loop {
match VotePoll::fetch_many(&sdk, end_time_query.clone()).await {
Ok(vote_polls) => {
for (timestamp, vote_poll_list) in vote_polls {
let contests = vote_poll_list.into_iter().filter_map(|vote_poll| {
let VotePoll::ContestedDocumentResourceVotePoll(
ContestedDocumentResourceVotePoll {
contract_id,
document_type_name,
index_name,
index_values,
},
) = vote_poll;
if contract_id != self.dpns_contract.id() {
return None;
}
if document_type_name != "domain" {
return None;
}
if index_name != "parentNameAndLabel" {
return None;
}
if index_values.len() != 2 {
return None;
}
index_values
.get(1)
.and_then(|a| a.to_str().ok().map(|a| (a.to_string(), timestamp)))
});
contests_end_times.extend(contests);
}
break;
}
if index_values.len() != 2 {
return None;
}
index_values
.get(1)
.and_then(|a| a.to_str().ok().map(|a| (a.to_string(), timestamp)))
});
Err(e) => {
tracing::error!("Error fetching vote polls: {}", e);
if let dash_sdk::Error::Proof(
dash_sdk::ProofVerifierError::GroveDBProofVerificationError {
proof_bytes,
path_query,
height,
time_ms,
error,
},
) = &e
{
// Encode the query using bincode
let encoded_query = match bincode::encode_to_vec(
&end_time_query,
bincode::config::standard(),
)
.map_err(|encode_err| {
tracing::error!("Error encoding query: {}", encode_err);
format!("Error encoding query: {}", encode_err)
}) {
Ok(encoded_query) => encoded_query,
Err(e) => return Err(e),
};

// Encode the path_query using bincode
let verification_path_query_bytes =
match bincode::encode_to_vec(&path_query, bincode::config::standard())
.map_err(|encode_err| {
tracing::error!("Error encoding path_query: {}", encode_err);
format!("Error encoding path_query: {}", encode_err)
}) {
Ok(encoded_path_query) => encoded_path_query,
Err(e) => return Err(e),
};

contests_end_times.extend(contests);
if let Err(e) = self
.db
.insert_proof_log_item(ProofLogItem {
request_type: RequestType::GetVotePollsByEndDate,
request_bytes: encoded_query,
verification_path_query_bytes,
height: *height,
time_ms: *time_ms,
proof_bytes: proof_bytes.clone(),
error: Some(error.clone()),
})
.map_err(|e| e.to_string())
{
return Err(e);
}
}
if e.to_string().contains("try another server")
|| e.to_string().contains(
"contract not found when querying from value with contract info",
)
{
retries += 1;
if retries > MAX_RETRIES {
tracing::error!("Max retries reached for query: {}", e);
return Err(format!("Error fetching vote polls after retries: {}", e));
} else {
// Retry
continue;
}
} else {
return Err(format!("Error fetching vote polls: {}", e));
}
}
}
}

self.db
.update_ending_time(contests_end_times, self)
.map_err(|e| format!("error updating ending time: {}", e))
.map_err(|e| format!("Error updating ending time: {}", e))
}
}