-
Notifications
You must be signed in to change notification settings - Fork 33
build(deps): update rand to 0.9.2, serde to 1.0.219 #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
rust-bindings/bls-signatures/Cargo.toml (1)
4-4: Remember to publish ancillary artifacts when bumping the crate versionThe crate version is now 1.3.5. Make sure:
CHANGELOG.md(if present) records the upgrade.- Doc links in
READMEor published guides reference 1.3.5.Cargo.lockis regenerated and committed for reproducible builds (if this repo tracks it).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
rust-bindings/bls-signatures/Cargo.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: ubuntu-latest, Python 3.9, Go 1.22
- GitHub Check: ubuntu-latest, Python 3.11, Go 1.22
- GitHub Check: js_bindings
- GitHub Check: ubuntu-latest, Python 3.10, Go 1.22
- GitHub Check: macos-latest, Python 3.12, Go 1.22
- GitHub Check: ubuntu-latest, Python 3.12, Go 1.22
- GitHub Check: macos-latest, Python 3.11, Go 1.22
- GitHub Check: macos-latest, autotools, gcc, easy backend
- GitHub Check: macos-latest, autotools, gcc, gmp backend
- GitHub Check: macos-latest, autotools, clang, gmp backend
🔇 Additional comments (1)
rust-bindings/bls-signatures/Cargo.toml (1)
17-18: rand 0.9 upgrade audit – no rand 0.8 usages foundFile: rust-bindings/bls-signatures/Cargo.toml
Lines: 17–18serde = { version = "1.0.219", features = ["derive"], optional = true } rand = { version = "0.9.2", optional = true }• No
rand = "0.8"pins detected across anyCargo.tomlin the workspace.
• No occurrences of removed rand 0.8 APIs (next_u32,next_u64,fill_bytes,gen_range()) in.rssources.
• Please verify that your Rust toolchain’s MSRV is ≥ 1.65 to satisfy rand 0.9 if not already.No further action required here.
1be9be9 to
419a136
Compare
|
pls change base branch and rebase on develop |
Summary by CodeRabbit