Skip to content

Run dwds tests in a copy of the sdk directory #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

Run dwds tests in a copy of the sdk directory #1967

wants to merge 18 commits into from

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Feb 16, 2023 •
edited
Loading

Test-only changes

Run tests using a copy of the Dart SDK directory so we don't pollute the default one with generated assets.

  • Pass a TestSdkConfigurationProvider toTestContext contsructor.
  • Make tests create and dispose of the SDK configuration provider as needed.
  • Make sure all commands run from tests use dart executable from the SDK copy.

Closes: #1985
Towards: #1878

@annagrin annagrin mentioned this pull request Feb 16, 2023
Closed
@annagrin annagrin marked this pull request as draft February 16, 2023 00:52
@annagrin annagrin mentioned this pull request Feb 16, 2023
Closed
13 tasks
@annagrin annagrin mentioned this pull request Feb 18, 2023
Merged
@annagrin annagrin changed the title Run tests in a copy of the sdk directory Run dwds tests in a copy of the sdk directory Feb 23, 2023
@annagrin
Copy link
Contributor Author

Closing this one - replaced by:

@annagrin annagrin closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests in a copy of the sdk directory
1 participant
@annagrin