Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 17.0.1-dev
## 18.0.0-dev

- Cleanup `getObject` code for lists and maps.
- Now works with offset `0` and `null` count.
Expand All @@ -9,6 +9,11 @@
- Update `package:dds` constraint to `^2.7.1`.
- Fill `BoundField.name` for records.
- Display records as a container of fields.
- Remove test-only code from `sdk_configuration.dart`.

**Breaking changes**
- Require `sdkConfigurationProvider` in `ExpressionCompilerService`
constructor.

## 17.0.0

Expand Down
10 changes: 10 additions & 0 deletions dwds/lib/sdk_configuration.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

export 'src/utilities/sdk_configuration.dart'
show
SdkLayout,
SdkConfiguration,
SdkConfigurationProvider,
DefaultSdkConfigurationProvider;
132 changes: 68 additions & 64 deletions dwds/lib/src/injected/client.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 4 additions & 6 deletions dwds/lib/src/services/expression_compiler_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -236,17 +236,15 @@ class ExpressionCompilerService implements ExpressionCompiler {
final List<String> experiments;
final bool _verbose;

final SdkConfigurationProvider _sdkConfigurationProvider;
final SdkConfigurationProvider sdkConfigurationProvider;

ExpressionCompilerService(
this._address,
this._port, {
bool verbose = false,
SdkConfigurationProvider sdkConfigurationProvider =
const DefaultSdkConfigurationProvider(),
required this.sdkConfigurationProvider,
this.experiments = const [],
}) : _verbose = verbose,
_sdkConfigurationProvider = sdkConfigurationProvider;
}) : _verbose = verbose;

@override
Future<ExpressionCompilationResult> compileExpressionToJs(
Expand All @@ -271,7 +269,7 @@ class ExpressionCompilerService implements ExpressionCompiler {
await _port,
moduleFormat,
soundNullSafety,
await _sdkConfigurationProvider.configuration,
await sdkConfigurationProvider.configuration,
experiments,
_verbose,
);
Expand Down
Loading