Fix incorrect list element count #1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 27, 2023 12:02
elliette
reviewed
Feb 8, 2023
elliette
reviewed
Feb 9, 2023
| /// Ignore any non-elements like 'length', 'fixed$length', etc. | ||
| static List<Property> _listElementProperties(List<Property> properties) => | ||
| properties | ||
| .where((p) => p.name != null && int.tryParse(p.name!) != null) |
There was a problem hiding this comment.
I think the lamda can be simplified to (p) => int.tryParse(p.name ?? '') != null because int.parse('') returns null.
There was a problem hiding this comment.
The original is faster though, so prefer to leave it as is for now.
elliette
reviewed
Feb 9, 2023
elliette
reviewed
Feb 9, 2023
elliette
reviewed
Feb 9, 2023
dwds/lib/src/debugging/instance.dart
Outdated
| } | ||
| /// Return only elements of the list from [properties]. | ||
| /// Ignore any non-elements like 'length', 'fixed$length', etc. | ||
| static List<Property> _listElementProperties(List<Property> properties) => |
There was a problem hiding this comment.
OOC, do you know why this is static?
There was a problem hiding this comment.
It does not need to access any methods or fields. Normally it is much faster to call static methods as they don't require a virtual table but I am not sure it is true for dart. There might be a lint for it as well, I'll try to find it.
elliette
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List instances received from getObject contain one extra element (comes from JavaScript Array.length property). Make sure we don't count the length field in the returned list instance.