Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
- Make hot restart atomic to prevent races on simultaneous execution.
- Return error on expression evaluation if expression evaluator stopped.
- Update SDK constraint to `>=3.0.0-134.0.dev <4.0.0`.
- Add optional `includeSubclasses` and `includeImplementers` parameters to
`ChromeProxyService.getInstances()`.

**Breaking changes**
- Include an optional param to `Dwds.start` to indicate whether it is running
Expand Down
7 changes: 6 additions & 1 deletion dwds/lib/src/services/chrome_proxy_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,12 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(

@override
Future<InstanceSet> getInstances(
String isolateId, String classId, int limit) {
String isolateId,
String classId,
int limit, {
bool? includeSubclasses,
bool? includeImplementers,
}) {
return _rpcNotSupportedFuture('getInstances');
}

Expand Down
2 changes: 1 addition & 1 deletion dwds/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ dependencies:
stack_trace: ^1.10.0
sse: ^4.1.2
uuid: ^3.0.6
vm_service: ^9.0.0
vm_service: ^10.1.0
web_socket_channel: ^2.2.0
webkit_inspection_protocol: ^1.0.1

Expand Down
4 changes: 4 additions & 0 deletions dwds/test/chrome_proxy_service_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,10 @@ void main() {

test('getInstances', () async {
await expectLater(service.getInstances('', '', 0), throwsRPCError);
await expectLater(
service.getInstances('', '', 0,
includeImplementers: true, includeSubclasses: true),
throwsRPCError);
});

group('getIsolate', () {
Expand Down