Skip to content

[MV3] Check if storage object exists before trying to read properties #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

[MV3] Check if storage object exists before trying to read properties #1883

merged 1 commit into from
Jan 11, 2023

Conversation

elliette
Copy link
Contributor

This fixes an error that was showing up for the MV3 debug extension. The error wasn't affecting any functionality, just logging to the console.

@elliette elliette requested a review from annagrin January 10, 2023 21:58
annagrin
annagrin approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 03d4035 into dart-lang:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@annagrin annagrin annagrin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @annagrin