Fix flaky CI tests #1848
Merged
Fix flaky CI tests #1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
changed the title
polina-c
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #1846 (flakiness caused by test timeouts):
Our
devtools_testkeeps timing out during CI testing. It already has a timeout limit of 5 minutes, so instead of increasing the timeout, this PR skips it with follow up work to schedule it on a cron job.The
debug_extension_testalso keeps timing out, this PR increases the timeout to 2 minutes.Work towards #1842 (flakiness cause by file path issues):
dwdsdirectory inTestContext, determine thedwdsdirectory and use that to create the various test directory paths.