Skip to content

Support --native-assets in FrontendServerClient #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

Support --native-assets in FrontendServerClient #1797

merged 1 commit into from
Nov 24, 2022

Conversation

dcharkes
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/264842 introduces passing --native-assets to gen_kernel.

This PR exposes this option in the FrontendServerClient so that it can be invoked from pub/dartdev which uses this API.

@dcharkes dcharkes mentioned this pull request Nov 24, 2022
Merged
sigurdm
sigurdm approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This should not break anything not using the option

@dcharkes dcharkes merged commit 637b406 into master Nov 24, 2022
@dcharkes
Copy link
Contributor Author

Thanks @sigurdm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcharkes @sigurdm