Skip to content

Migrate remaining webdev libraries #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2022
Merged

Migrate remaining webdev libraries #1763

merged 3 commits into from
Oct 21, 2022

Conversation

natebosch
Copy link
Member

Closes #1640

Migrate the last unmigrated libraries from lib/ as well as the binary.

@natebosch
Migrate remaining webdev libraries
56bd7eb 
Migrate the last unmigrated libraries from `lib/` as well as the binary.
@natebosch natebosch requested a review from elliette October 20, 2022 20:29
elliette
elliette reviewed Oct 21, 2022
View reviewed changes
elliette
elliette reviewed Oct 21, 2022
View reviewed changes
elliette
elliette reviewed Oct 21, 2022
View reviewed changes
elliette
elliette reviewed Oct 21, 2022
View reviewed changes
elliette
elliette approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Added a few requests

@natebosch
Review
041795c 
Make DevWorkflow.serverManager non-null.

Pull out extraArgs with a fallback to empty list.

Make AppState fields non-null
@natebosch natebosch merged commit c350055 into master Oct 21, 2022
@natebosch natebosch deleted the finish-webdev-migration branch October 21, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Found 34 files excluded from sound null safety in webdev/
2 participants
@natebosch @elliette