Skip to content

Migrate some test fixtures in DWDS to null-safety #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Migrate some test fixtures in DWDS to null-safety #1679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19b45e4
Migrate some test fixtures to null-safety
elliette Jul 11, 2022
0beca2c
Dart format
elliette Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dwds/test/fixtures/debugger_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart = 2.9

/// Contains hard-coded test data usable for tests.
import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';

Expand Down
10 changes: 4 additions & 6 deletions dwds/test/fixtures/logging.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,15 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart = 2.9

import 'dart:async';

import 'package:logging/logging.dart';
import 'package:test/test.dart';

typedef LogWriter = void Function(Level level, String message,
{String error, String loggerName, String stackTrace});
{String? error, String? loggerName, String? stackTrace});

StreamSubscription<LogRecord> _loggerSub;
StreamSubscription<LogRecord>? _loggerSub;

/// Redirect the logs for the current zone to emit on failure.
///
Expand Down Expand Up @@ -49,7 +47,7 @@ void setCurrentLogWriter({bool debug = false}) =>
///
/// Tests and groups of tests can use this to configure individual
/// log writers on setup.
void configureLogWriter({LogWriter customLogWriter}) {
void configureLogWriter({LogWriter? customLogWriter}) {
_logWriter = customLogWriter ?? _logWriter;
Logger.root.level = Level.ALL;
_loggerSub?.cancel();
Expand All @@ -69,7 +67,7 @@ void stopLogWriter() {
LogWriter _logWriter = createLogWriter();

LogWriter createLogWriter({bool debug = false}) =>
(level, message, {String error, String loggerName, String stackTrace}) {
(level, message, {String? error, String? loggerName, String? stackTrace}) {
final printFn = debug ? print : printOnFailure;
final errorMessage = error == null ? '' : ':\n$error';
final stackMessage = stackTrace == null ? '' : ':\n$stackTrace';
Expand Down
2 changes: 0 additions & 2 deletions dwds/test/fixtures/utilities.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart = 2.9

import 'dart:io';

import 'package:build_daemon/client.dart';
Expand Down