[interop] Add support for destructured parameters #469
+170
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for working with destructured parameters, as well as other kind of parameters. These take the place of the param type, since destructuring in parameters is not allowed in Dart. However, this goes a step further and provides documentation on the parameter itself, providing the form of the param as documentation. Signed-off-by: Nike Okoronkwo <[email protected]>
nikeokoronkwo
changed the title
srujzs
approved these changes
Sep 22, 2025
| external double firstTwoNumbers( | ||
|
|
||
| /// Parameter is of the form: [a, b] | ||
| _i1.JSArray<_i1.JSNumber> arr117); |
There was a problem hiding this comment.
Can this not be a JSTuple$N type?
There was a problem hiding this comment.
Yes it could, but the user may be interfacing with an API that sends down some data in a certain format, and [number, number] !== number[].
| ({ a: number } | { b: string }) & | ||
| ({ c: boolean } | ({ d: bigint } & { e: symbol })); | ||
| export declare function firstTwoNumbers([a, b]: number[]): number; | ||
| export declare function productInfo({ name, id }: Product, options?: { search?: boolean, showId?: boolean }): string; |
There was a problem hiding this comment.
Interesting! What is the purpose of this? Is it saying "I don't care about any values besides name and id"?
There was a problem hiding this comment.
Yes.
The user may just care about only the name and id (the purpose of normal destructuring).
(it would be nice to have something like this in Dart)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for working with destructured parameters, as well as other kind of parameters. These take the place of the param type, since destructuring in parameters is not allowed in Dart.
However, this goes a step further and provides documentation on the parameter itself, providing the form of the param as documentation.