[interop] Resolved Namespace typedef and exception improvements
#459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improved exception for not finding type - resolved def if cannot find file in path/module (i.e maybe a module already resolved by ts/node)
srujzs
reviewed
Aug 25, 2025
|
Ready now. |
firminograzielle697-stack
approved these changes
Sep 1, 2025
firminograzielle697-stack
approved these changes
Sep 1, 2025
srujzs
approved these changes
Sep 2, 2025
| name: name, | ||
| dartName: dartName, | ||
| id: id, | ||
| exported: isExported, |
There was a problem hiding this comment.
FYI, we may have talked about this before but this is for supporting properties that aren't strictly identifiers in JS interop: https://dart-review.googlesource.com/c/sdk/+/447964. This would allow things like @JS('foo-bar').
There was a problem hiding this comment.
Affirmative, although this may not help/work with symbol indexing. Would this work for number indexes as well?
There was a problem hiding this comment.
Just to reference the issue: dart-lang/sdk#61413
|
I think we still need a test for a typedef in a namespace unless that was the test expectation that got updated? |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 4, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/d6370fb..36e514d): 36e514d 2025-09-02 dependabot[bot] Bump the github-actions group with 4 updates (dart-lang/ecosystem#368) 7c783fa 2025-09-02 Devon Carew update to the latest analyzer (dart-lang/ecosystem#369) web (https://github.com/dart-lang/web/compare/bdab462..a152054): a152054 2025-09-03 Nikechukwu [interop] Resolved Namespace `typedef` and exception improvements (dart-lang/web#459) webdev (https://github.com/dart-lang/webdev/compare/bf7b1e5..52ad019): 52ad0191 2025-09-03 jensjoha Fix failing test ('NoSuchAlertException (27): no such alert') after `#2681` (dart-lang/webdev#2683) Change-Id: Ib708d6855f0aa2b6502137526f798a3780fa3048 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448420 Reviewed-by: Nate Bosch <[email protected]> Commit-Queue: Devon Carew <[email protected]>
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of fixes to the web-generator, as well as some minor additions to previous features
typedefin namespaces