code_builder: update deps, prepare release #2160
Conversation
github-actions
bot
added
type-infra
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @kevmoo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request finalizes the version number for the code_builder package and updates all its dependencies, including the minimum Dart SDK requirement. This ensures the package remains compatible with the latest Dart ecosystem and leverages improvements from updated libraries, preparing it for a stable release.
Highlights
- Package Version Update: The code_builder package version has been updated from 4.10.2-wip to 4.10.2, indicating preparation for a new release.
- Dart SDK Requirement Bump: The minimum required Dart SDK version has been increased from ^3.6.0 to ^3.7.0, aligning with newer language features and ecosystem changes.
- Dependency Upgrades: Numerous direct and development dependencies have been upgraded to their latest compatible versions, including built_collection, built_value, collection, matcher, meta, build, build_runner, built_value_generator, dart_style, source_gen, and test.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| * Consistently add blank lines between `=>` in class-like definitions. | ||
| * Fixed bug: Fields declared with `static` and `external` now produce code with | ||
| correct order | ||
| * Upgrade `dart_style` and `source_gen` to remove `package:macros` dependency. |
There was a problem hiding this comment.
No need to document updates to dev dependencies
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
| collection: ^1.15.0 | ||
| matcher: ^0.12.10 | ||
| meta: ^1.3.0 | ||
| built_collection: ^5.1.1 |
There was a problem hiding this comment.
Updated with _PUB_TEST_SDK_VERSION=3.7.0 dart pub downgrade --tighten
There was a problem hiding this comment.
Thanks - I'm always forgetting that incantation. Perhaps we could add some cli flags to pub to make running the above easier?
There was a problem hiding this comment.
Or dart pub downgrade --tighten could be changed to assume that it was running in the context of the pub sdk constraint version?
There was a problem hiding this comment.
We should have a (public) flag for this. _PUB_TEST_SDK_VERSION is pub impl silliness.
There was a problem hiding this comment.
Code Review
This pull request prepares for a new release by updating the version to 4.10.2 and bumping several dependencies. The changes in pubspec.yaml are correctly reflected in the CHANGELOG.md for runtime dependencies. I've suggested a small improvement to the changelog to also mention the updated development dependencies for better transparency.
| collection: ^1.15.0 | ||
| matcher: ^0.12.10 | ||
| meta: ^1.3.0 | ||
| built_collection: ^5.1.1 |
There was a problem hiding this comment.
Thanks - I'm always forgetting that incantation. Perhaps we could add some cli flags to pub to make running the above easier?
| collection: ^1.15.0 | ||
| matcher: ^0.12.10 | ||
| meta: ^1.3.0 | ||
| built_collection: ^5.1.1 |
There was a problem hiding this comment.
Or dart pub downgrade --tighten could be changed to assume that it was running in the context of the pub sdk constraint version?
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with
Coverage
|
| File | Coverage |
|---|---|
| pkgs/code_builder/example/example.dart | 💔 Not covered |
| pkgs/code_builder/lib/code_builder.dart | 💔 Not covered |
| pkgs/code_builder/lib/src/allocator.dart | 💚 100 % |
| pkgs/code_builder/lib/src/emitter.dart | 💔 98 % ⬇️ 0 % |
| pkgs/code_builder/lib/src/matchers.dart | 💚 100 % |
| pkgs/code_builder/lib/src/specs/class.dart | 💚 80 % |
| pkgs/code_builder/lib/src/specs/code.dart | 💚 77 % |
| pkgs/code_builder/lib/src/specs/directive.dart | 💚 98 % ⬆️ 0 % |
| pkgs/code_builder/lib/src/specs/enum.dart | 💚 100 % |
| pkgs/code_builder/lib/src/specs/expression.dart | 💚 97 % ⬆️ 0 % |
| pkgs/code_builder/lib/src/specs/expression/invoke.dart | 💚 71 % |
| pkgs/code_builder/lib/src/specs/expression/literal.dart | 💔 80 % ⬇️ 3 % |
| pkgs/code_builder/lib/src/specs/extension.dart | 💚 100 % |
| pkgs/code_builder/lib/src/specs/extension_type.dart | 💚 60 % |
| pkgs/code_builder/lib/src/specs/field.dart | 💚 100 % |
| pkgs/code_builder/lib/src/specs/library.dart | 💚 100 % |
| pkgs/code_builder/lib/src/specs/method.dart | 💚 75 % |
| pkgs/code_builder/lib/src/specs/mixin.dart | 💚 100 % |
| pkgs/code_builder/lib/src/specs/reference.dart | 💚 100 % |
| pkgs/code_builder/lib/src/specs/type_function.dart | 💚 38 % |
| pkgs/code_builder/lib/src/specs/type_record.dart | 💚 27 % |
| pkgs/code_builder/lib/src/specs/type_reference.dart | 💚 26 % |
| pkgs/code_builder/lib/src/specs/typedef.dart | 💚 100 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/bazel_worker/benchmark/benchmark.dart |
| pkgs/bazel_worker/example/client.dart |
| pkgs/bazel_worker/example/worker.dart |
| pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart |
| pkgs/boolean_selector/example/example.dart |
| pkgs/clock/lib/clock.dart |
| pkgs/clock/lib/src/clock.dart |
| pkgs/clock/lib/src/default.dart |
| pkgs/clock/lib/src/stopwatch.dart |
| pkgs/clock/lib/src/utils.dart |
| pkgs/clock/test/clock_test.dart |
| pkgs/clock/test/default_test.dart |
| pkgs/clock/test/stopwatch_test.dart |
| pkgs/clock/test/utils.dart |
| pkgs/coverage/lib/src/coverage_options.dart |
| pkgs/html/example/main.dart |
| pkgs/html/lib/dom.dart |
| pkgs/html/lib/dom_parsing.dart |
| pkgs/html/lib/html_escape.dart |
| pkgs/html/lib/parser.dart |
| pkgs/html/lib/src/constants.dart |
| pkgs/html/lib/src/encoding_parser.dart |
| pkgs/html/lib/src/html_input_stream.dart |
| pkgs/html/lib/src/list_proxy.dart |
| pkgs/html/lib/src/query_selector.dart |
| pkgs/html/lib/src/token.dart |
| pkgs/html/lib/src/tokenizer.dart |
| pkgs/html/lib/src/treebuilder.dart |
| pkgs/html/lib/src/utils.dart |
| pkgs/html/test/dom_test.dart |
| pkgs/html/test/parser_feature_test.dart |
| pkgs/html/test/parser_test.dart |
| pkgs/html/test/query_selector_test.dart |
| pkgs/html/test/selectors/level1_baseline_test.dart |
| pkgs/html/test/selectors/level1_lib.dart |
| pkgs/html/test/selectors/selectors.dart |
| pkgs/html/test/support.dart |
| pkgs/html/test/tokenizer_test.dart |
| pkgs/html/test/trie_test.dart |
| pkgs/html/tool/generate_trie.dart |
| pkgs/pubspec_parse/test/git_uri_test.dart |
| pkgs/stack_trace/example/example.dart |
| pkgs/watcher/test/custom_watcher_factory_test.dart |
| pkgs/yaml_edit/example/example.dart |
This check can be disabled by tagging the PR with skip-license-check.
| ## 4.10.2-wip | ||
| ## 4.11.0 | ||
|
|
||
| * Export `SpecVisitor`, `ClosureExpression`, `LiteralMapExpression` |
There was a problem hiding this comment.
FYI (@devoncarew) exporting "leaked" types.
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/efff7c1..49fc272): 49fc272d 2025-09-10 Sarah Zakarias Remove "parsedConstructorHint" from "PrefixResultType" (dart-lang/dartdoc#4104) tools (https://github.com/dart-lang/tools/compare/24707e0..319be98): 319be98a 2025-09-10 Kevin Moore code_builder: update deps, prepare release (dart-lang/tools#2160) Change-Id: Ie29458707709a45617cead36f33e39725e33f966 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449071 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
No description provided.