Skip to content

Bring up to analyzer 8.1.1, get rid of deprecated classes and methods. #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fshcheglov
Copy link

Also deleted

    if (element case final Annotatable annotatable) {
      final annotations = annotatable.metadata2.annotations;
      if (annotations.isEmpty) {
        return null;
      }
    }

from source_gen/lib/src/type_checker.dart because it repeated a check that was done a few lines later.

@fshcheglov fshcheglov changed the title Bring up to dart 8.1.1, get rid of deprecated classes and methods. Bring up to analyzer 8.1.1, get rid of deprecated classes and methods. Aug 18, 2025
@davidmorgan
Copy link
Contributor

Thanks! Also, hi, Konstantin mentioned you have started contributing to Dart :)

I'm not sure if we want to drop support for analyzer 7 quite yet, but there should not be many code changes so we can use this when we do.

The reason I am not sure is that for #775 we want to do a breaking change / major version release of source_gen: remove all mirrors use then bump to 4.0.0. It might make sense to do that before dropping support for analyzer 7. It's an easy change so maybe we should just do that ... on the other hand maybe we can think of something else we should do before either of the two :)

@kevmoo any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants