Skip to content

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 8, 2025

New process!

Now that we have a pub workspace, we don't have to flip to published dependency anymore in a follow up commit. We simply update the version number everywhere in one commit.

Copy link

github-actions bot commented Apr 8, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes force-pushed the nac-0-14 branch 2 times, most recently from c078c00 to c601983 Compare April 8, 2025 10:49
Base automatically changed from remove-path-deps to main April 8, 2025 15:22
Copy link

github-actions bot commented Apr 8, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:ffi 2.1.4 already published at pub.dev
package:ffigen 18.1.0-wip WIP (no publish necessary)
package:jni 0.14.1 already published at pub.dev
package:jnigen 0.14.2-wip WIP (no publish necessary)
package:native_assets_cli 0.14.0 ready to publish native_assets_cli-v0.14.0
package:objective_c 7.1.0-wip WIP (no publish necessary)
package:swift2objc 0.0.1-wip WIP (no publish necessary)
package:swiftgen 0.0.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@auto-submit auto-submit bot removed the autosubmit label Apr 8, 2025
Copy link

auto-submit bot commented Apr 8, 2025

autosubmit label was removed for dart-lang/native/2181, because - The status or check suite health / leaking / run leaking health check has failed. Please fix the issues identified (or deflake) before re-applying this label.

@coveralls
Copy link

Coverage Status

coverage: 84.832%. remained the same
when pulling aa7d9d2 on nac-0-14
into e6549b4 on main.

@dcharkes
Copy link
Collaborator Author

dcharkes commented Apr 8, 2025

"breaking" and "leaking" checks should be fixed by:

I've run the checks locally.

Copy link

auto-submit bot commented Apr 8, 2025

autosubmit label was removed for dart-lang/native/2181, because - The status or check suite health / leaking / run leaking health check has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dcharkes dcharkes merged commit a742704 into main Apr 8, 2025
75 of 81 checks passed
@dcharkes dcharkes deleted the nac-0-14 branch April 8, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants