Only set the charset when the body is set for certain mime types

[brianquinlan]

Fixes #1438

NOTE: The charset parameter is not defined for application/x-www-form-urlencoded so the changes to those tests should not break anything.

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[github-actions]

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:cronet_http	1.5.0	already published at pub.dev
package:cupertino_http	2.4.0-wip	WIP (no publish necessary)
package:http	1.6.0-wip	WIP (no publish necessary)
package:http2	3.0.0	ready to publish	http2-v3.0.0
package:http_multi_server	3.2.2	already published at pub.dev
package:http_parser	4.1.2	already published at pub.dev
package:http_profile	0.1.1-wip	WIP (no publish necessary)
package:ok_http	0.1.1-wip	WIP (no publish necessary)
package:web_socket	1.0.1	already published at pub.dev
package:web_socket_channel	3.0.3	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[github-actions]

PR Health

Breaking changes ⚠️

Package	Change	Current Version	New Version	Needed Version	Looking good?
cronet_http	None	1.5.0	1.5.0	1.5.0	✔️
cupertino_http	Breaking	2.3.0	2.4.0-wip	3.0.0 Got "2.4.0-wip" expected >= "3.0.0" (breaking changes)	⚠️
http	None	1.5.0	1.6.0-wip	1.5.0	✔️
ok_http	Non-Breaking	0.1.0	0.1.1-wip	0.1.1	✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ❗

Package	Changed Files
package:cronet_http	pkgs/cronet_http/example/pubspec.yaml
package:cupertino_http	pkgs/cupertino_http/example/pubspec.yaml
package:ok_http	pkgs/ok_http/example/pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️

File	Coverage
pkgs/http/lib/src/request.dart	💚 98 % ⬆️ 0 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbol	Leaking sources
cupertino_http	ncb.NSURLCache	cupertino_api.dart::URLCache native_cupertino_bindings.dart::NSURLCache::getSharedURLCache native_cupertino_bindings.dart::NSURLCache::setSharedURLCache::value native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity$1 native_cupertino_bindings.dart::NSURLCache::init native_cupertino_bindings.dart::NSURLCache::new$ native_cupertino_bindings.dart::NSURLCache::allocWithZone native_cupertino_bindings.dart::NSURLCache::alloc native_cupertino_bindings.dart::NSURLCache::self$1 native_cupertino_bindings.dart::NSURLCache::retain native_cupertino_bindings.dart::NSURLCache::autorelease native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache
cupertino_http	NSURLRequest	native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest::request native_cupertino_bindings.dart::NSURLRequest::requestWithURL native_cupertino_bindings.dart::NSURLRequest::requestWithURL$1 native_cupertino_bindings.dart::NSURLRequest::initWithURL native_cupertino_bindings.dart::NSURLRequest::initWithURL$1 native_cupertino_bindings.dart::NSURLRequest::init native_cupertino_bindings.dart::NSURLRequest::new$ native_cupertino_bindings.dart::NSURLRequest::allocWithZone native_cupertino_bindings.dart::NSURLRequest::alloc native_cupertino_bindings.dart::NSURLRequest::self$1 native_cupertino_bindings.dart::NSURLRequest::retain native_cupertino_bindings.dart::NSURLRequest::autorelease native_cupertino_bindings.dart::NSURLRequest::initWithCoder native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::forRequest native_cupertino_bindings.dart::NSURLCache::removeCachedResponseForRequest::request
cupertino_http	NSURLRequestAttribution	native_cupertino_bindings.dart::NSURLRequest::attribution native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionDeveloper native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionUser native_cupertino_bindings.dart::NSURLRequestAttribution::values native_cupertino_bindings.dart::NSURLRequestAttribution::fromValue
cupertino_http	NSCachedURLResponse	native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::cachedResponse
cupertino_http	ncb.NSURLSessionDelegate	cupertino_api.dart::URLSession::delegate
cupertino_http	ncb.NSURLSessionConfiguration	cupertino_api.dart::URLSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::getDefaultSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::getEphemeralSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::backgroundSessionConfigurationWithIdentifier native_cupertino_bindings.dart::NSURLSessionConfiguration::init native_cupertino_bindings.dart::NSURLSessionConfiguration::new$ native_cupertino_bindings.dart::NSURLSessionConfiguration::allocWithZone native_cupertino_bindings.dart::NSURLSessionConfiguration::alloc native_cupertino_bindings.dart::NSURLSessionConfiguration::self$1 native_cupertino_bindings.dart::NSURLSessionConfiguration::retain native_cupertino_bindings.dart::NSURLSessionConfiguration::autorelease
cupertino_http	SSLProtocol	native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolUnknown native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol11 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol12 native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol1 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol13 native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol12 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocolMaxSupported native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol2 native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3 native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3Only native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1Only native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolAll native_cupertino_bindings.dart::SSLProtocol::values native_cupertino_bindings.dart::SSLProtocol::fromValue native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol
cupertino_http	tls_protocol_version_t	native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv10 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv11 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv12 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv13 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv10 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv12 native_cupertino_bindings.dart::tls_protocol_version_t::values native_cupertino_bindings.dart::tls_protocol_version_t::fromValue native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion
cupertino_http	NSHTTPCookieStorage	native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage
cupertino_http	NSURLCredentialStorage	native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage
ok_http	$Certificate$NullableType	jni/bindings.dart::Certificate::nullableType
ok_http	$Certificate$Type	jni/bindings.dart::Certificate::type
ok_http	PublicKey	jni/bindings.dart::Certificate::verify::publicKey jni/bindings.dart::$PublicKey$NullableType jni/bindings.dart::$PublicKey$NullableType::nullableType jni/bindings.dart::$PublicKey$Type jni/bindings.dart::$PublicKey$Type::nullableType jni/bindings.dart::Certificate::verify$1::publicKey jni/bindings.dart::Certificate::verify$2::publicKey jni/bindings.dart::Certificate::getPublicKey jni/bindings.dart::X509Certificate::verify2::publicKey
ok_http	$PublicKey$NullableType	jni/bindings.dart::PublicKey::nullableType
ok_http	$PublicKey$Type	jni/bindings.dart::PublicKey::type
ok_http	$PublicKey	jni/bindings.dart::PublicKey::implementIn::$impl jni/bindings.dart::PublicKey::implement::$impl
ok_http	$X509Certificate$NullableType	jni/bindings.dart::X509Certificate::nullableType
ok_http	$X509Certificate$Type	jni/bindings.dart::X509Certificate::type
ok_http	$PrivateKey$NullableType	jni/bindings.dart::PrivateKey::nullableType
ok_http	$PrivateKey$Type	jni/bindings.dart::PrivateKey::type
ok_http	$PrivateKey	jni/bindings.dart::PrivateKey::implementIn::$impl jni/bindings.dart::PrivateKey::implement::$impl

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/http/example/main.dart

This check can be disabled by tagging the PR with skip-license-check.

[mraleph]

LGTM!