Skip to content

Conversation

dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Aug 27, 2025

@dcharkes
Copy link
Contributor Author

Thanks for the quick review! 🙏

Do we need to bump firehose to a non-wip version to release this @mosuem ?

Copy link

github-actions bot commented Aug 27, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
firehose None 0.11.0 0.12.1-wip 0.11.0 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage
pkgs/firehose/lib/src/health/health.dart 💚 94 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

@dcharkes dcharkes changed the title Update apiToolHash constant value [health] Bump dart_apitool Aug 27, 2025
@auto-submit auto-submit bot merged commit d6370fb into main Sep 1, 2025
24 checks passed
@auto-submit auto-submit bot deleted the bump-apitool branch September 1, 2025 06:52
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Sep 2, 2025
…, webdev, webdriver

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/a9eb685..1547a83):
  1547a83  2025-08-29  Jaime Wren  Fix the capitalization of the Cursor editor in the flag description (dart-lang/ai#276)

core (https://github.com/dart-lang/core/compare/b59ecf4..5c3e2c3):
  5c3e2c38  2025-09-02  dependabot[bot]  Bump actions/checkout from 4.2.2 to 5.0.0 in the github-actions group (dart-lang/core#904)

ecosystem (https://github.com/dart-lang/ecosystem/compare/fd28be2..d6370fb):
  d6370fb  2025-08-31  Daco Harkes  [health] Bump dart_apitool (dart-lang/ecosystem#367)

i18n (https://github.com/dart-lang/i18n/compare/9a211d1..a62bed2):
  a62bed2c  2025-09-01  dependabot[bot]  Bump actions/download-artifact in the github-actions group (dart-lang/i18n#1007)

protobuf (https://github.com/dart-lang/protobuf/compare/765ba8a..0a13935):
  0a13935  2025-09-02  dependabot[bot]  Bump actions/checkout from 4.2.2 to 5.0.0 (google/protobuf.dart#1046)

shelf (https://github.com/dart-lang/shelf/compare/400fc39..de91a5b):
  de91a5b  2025-09-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/shelf#481)

sync_http (https://github.com/dart-lang/sync_http/compare/c07f96f..6666fff):
  6666fff  2025-09-02  dependabot[bot]  Bump actions/checkout from 4.2.2 to 5.0.0 (google/sync_http.dart#56)

web (https://github.com/dart-lang/web/compare/e7895bd..bdab462):
  bdab462  2025-09-01  dependabot[bot]  Bump actions/checkout from 4.2.2 to 5.0.0 in the github-actions group (dart-lang/web#462)
  d93ce7b  2025-08-29  Nikechukwu  [web_generator] Updated README (dart-lang/web#461)

webdev (https://github.com/dart-lang/webdev/compare/a7d3d2f..bf7b1e5):
  bf7b1e59  2025-09-02  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/webdev#2684)
  769a0568  2025-08-29  Ben Konyi  [ DWDS ] Serve DevTools from DDS by default (dart-lang/webdev#2681)

webdriver (https://github.com/google/webdriver.dart/compare/595649d..09104f4):
  09104f4  2025-09-02  dependabot[bot]  Bump actions/checkout from 4.2.2 to 5.0.0 (google/webdriver.dart#332)
  5fbbbaa  2025-09-02  dependabot[bot]  Bump nanasess/setup-chromedriver (google/webdriver.dart#333)

Change-Id: Ib6275cc21e3a989142c46b59b1005277f3621db1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448222
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants