Stop using TypeDefiningElement. #4112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
approved these changes
Oct 2, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 6, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/669b15f..ec2a4fe): ec2a4fee 2025-10-06 dependabot[bot] Bump test_reflective_loader from 0.2.3 to 0.4.0 (dart-lang/dartdoc#4111) 2ec3e4ef 2025-10-02 Konstantin Scheglov Stop using TypeDefiningElement. (dart-lang/dartdoc#4112) f65c7e21 2025-10-01 dependabot[bot] Bump the github-actions group with 3 updates (dart-lang/dartdoc#4113) ecosystem (https://github.com/dart-lang/ecosystem/compare/36e514d..96ee861): 96ee861 2025-10-02 Devon Carew misc repo metadata updates (dart-lang/ecosystem#372) 0d7ffaa 2025-10-02 Moritz Rename comments (dart-lang/ecosystem#373) a3cf960 2025-10-01 dependabot[bot] Bump the github-actions group with 5 updates (dart-lang/ecosystem#374) test (https://github.com/dart-lang/test/compare/a16f149..8083c8f): 8083c8f2 2025-10-03 Nate Bosch Make all package:coverage imports conditional (dart-lang/test#2544) tools (https://github.com/dart-lang/tools/compare/ce9d2ad..6866f9b): 6866f9b1 2025-10-06 Morgan :) Allow more time for tests on Windows. (dart-lang/tools#2193) 1264445e 2025-10-06 Morgan :) Fix flaky test on Windows. (dart-lang/tools#2192) webdev (https://github.com/dart-lang/webdev/compare/0b2a408..29ba1b1): 29ba1b12 2025-10-01 dependabot[bot] Bump the github-actions group with 3 updates (dart-lang/webdev#2693) Change-Id: I9582b0380b2b974a2d05ab4f77c67c14e92aaa63 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/453580 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to remove it from the analyzer's element model.
It does not look that it was used for something specific in DartDoc.
I also renamed
documentableElement2intodocumentableElement.Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.