Skip to content

Remove "parsedConstructorHint" from "PrefixResultType" #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

Remove "parsedConstructorHint" from "PrefixResultType" #4104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/src/comment_references/parser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,6 @@ class CommentReferenceParser {
if (prefixResult.type == _PrefixResultType.endOfFile) {
return [];
}
if (prefixResult.type == _PrefixResultType.parsedConstructorHint) {
children.add(prefixResult.node!);
}
// [_PrefixResultType.junk] and [_PrefixResultType.missing] we can skip.

// <commentReference>
Expand Down Expand Up @@ -370,7 +367,6 @@ enum _PrefixResultType {
endOfFile, // Found end of file instead of a prefix.
junk, // Found some recognized junk that can be ignored.
missing, // There is no prefix here.
parsedConstructorHint, // Parsed a [ConstructorHintStartNode].
}

/// The result of attempting to parse a prefix to a comment reference.
Expand Down
2 changes: 1 addition & 1 deletion test/comment_referable/parser_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import 'package:test/test.dart';

void main() {
void expectParseEquivalent(String codeRef, List<String> parts,
{bool constructorHint = false, bool callableHint = false}) {
{bool callableHint = false}) {
var result = CommentReferenceParser(codeRef).parse();
var hasCallableHint =
result.isNotEmpty && result.last is CallableHintEndNode;
Expand Down
Loading