Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Conversation

@lrhn
Copy link
Contributor

@lrhn lrhn commented Feb 7, 2024

The wonders of in-IDE spell checking.
Also ask for newest lints (no changes needed).

The wonders of in-IDE spell checking.
Also ask for newest lints (no changes needed).
@lrhn lrhn requested a review from natebosch February 7, 2024 18:53
/// If [minVersion] is greater than the version read from the
/// `package_config.json` file, it too is ignored.
Future<PackageConfig?> findPackagConfigInDirectory(Directory directory,
Future<PackageConfig?> findPackageConfigInDirectory(Directory directory,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Consider making this private since it is not referenced outside this library.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will consider for a later cleanup.

@lrhn lrhn merged commit 854dc19 into master Apr 11, 2024
@lrhn lrhn deleted the fix-typos branch April 11, 2024 06:56
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 11, 2024
…source_map_stack_trace, source_maps

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/b2e2224..5c83bc9):
  5c83bc9  2024-04-11  Devon Carew  rev to 2.5.0 and prep to publish (dart-archive/args#267)

cli_util (https://github.com/dart-lang/cli_util/compare/12cd216..e222c56):
  e222c56  2024-04-11  Lasse R.H. Nielsen  Make `sdkPath` a getter (dart-archive/cli_util#100)

ecosystem (https://github.com/dart-lang/ecosystem/compare/de03da1..95fed18):
  95fed18  2024-04-09  Kevin Moore  dart_flutter_team_lints: bump pkg:checks dev dep (dart-lang/ecosystem#250)

http (https://github.com/dart-lang/http/compare/caad9ca..b7477b1):
  b7477b1  2024-04-10  Hossein Yousefi  Upgrade jni and jnigen to 0.8.0 (dart-lang/http#1176)

mockito (https://github.com/dart-lang/mockito/compare/3ef744f..81ecb88):
  81ecb88  2024-04-11  Ilya Yanok  Fix one README example that were broken by dart-lang/mockito@1dcd822 Also sync the executable version of it with the README.

package_config (https://github.com/dart-lang/package_config/compare/486cc4b..854dc19):
  854dc19  2024-04-11  Lasse R.H. Nielsen  Fix typos. (dart-archive/package_config#147)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/d03fd9b..9ed8875):
  9ed8875  2024-04-10  Kevin Moore  Update the latest version of lints (dart-archive/source_map_stack_trace#50)
  5f7f3a7  2024-04-09  Kevin Moore  blast_repo fixes (dart-archive/source_map_stack_trace#49)

source_maps (https://github.com/dart-lang/source_maps/compare/64d07fa..aedfc39):
  aedfc39  2024-04-09  Kevin Moore  blast_repo fixes (dart-archive/source_maps#89)
  45a66c3  2024-04-09  Kevin Moore  Bump lints, require Dart 3.3 (dart-archive/source_maps#88)

Change-Id: Ibe7c030b2b7377ecb5fe81d05ae1df605da1ec6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362193
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
The wonders of in-IDE spell checking.
Also ask for newest lints (no changes needed).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants