Initial JPEG XL decoder #755
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmilos
force-pushed
the
kmilos/dng_jxl
branch
7 times, most recently
from
0723adc to
2610804
Compare
1 task
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (status == JXL_DEC_NEED_IMAGE_OUT_BUFFER) { | ||
| size_t size = | ||
| basicinfo.xsize * basicinfo.ysize * basicinfo.num_color_channels; |
Check warning
Code scanning / CodeChecker
The left operand of '*' is a garbage value
| JxlDecoderDestroy(decoder); | ||
|
|
||
| const Array2DRef<uint16_t> tmp(complete_buffer.data(), | ||
| basicinfo.num_color_channels * basicinfo.xsize, |
Check warning
Code scanning / CodeChecker
The left operand of '*' is a garbage value
|
The proposed diff is not cd <path/to/repo/checkout> # NOTE: use your own path here
unzip clang-format.patch.zip
git stash # Temporairly stash away any preexisting diff
git apply clang-format.patch # Apply the diff
git add -u # Stage changed files
git commit -m "Applying clang-format" # Commit the patch
git push
git stash pop # Unstast preexisting diff
rm clang-format.patch.zip clang-format.patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs. #516
This is just a basic POC, largely based around the darktable imageio_jxl reader.