Skip to content

Conversation

@kmilos
Copy link
Collaborator

@kmilos kmilos commented May 13, 2021

Uses ARW DefaultCropOrigin+DefaultCropSize.

Absolute (positive) size is used instead of the preferred relative (negative) one because the new JPEG lossless compressed ARW mode uses tiles and has a different (larger) ImageWidth/ImageLenght to the usual uncompressed & lossy compressed modes, so this should be future proof.

Closes darktable-org/darktable#8618 (w/o lossless compression; adobe_coeffs already in dt master)

@kmilos kmilos requested a review from LebedevRI as a code owner May 13, 2021 14:31
@nschroeter
Copy link

Any updates to this, the code changes seem to be quite trivial?

@ashic
Copy link

ashic commented Jun 8, 2021

Would really appreciate this getting in. Currently editing raw file metadata to say it's the A7Riv, but on opening, the default settings look dark. Works ok after adjustments, but having the camera supported would be great.

@LebedevRI LebedevRI merged commit efdf631 into darktable-org:develop Jun 9, 2021
@kmilos kmilos deleted the patch-3 branch June 9, 2021 13:37
@nschroeter
Copy link

@LebedevRI Great, thank you so much!

@LebedevRI
Copy link
Member

@kmilos please stop using "fixes #xyz" in commit messages

@kmilos
Copy link
Collaborator Author

kmilos commented Jun 9, 2021

@LebedevRI noted - I assumed it would help w/ the "basic" triage, but now I see it might actually complicate schemes like "New Camera Support" cards you're using, sorry!

@LebedevRI
Copy link
Member

IMHO only having a single camera support request issue (with meaningful name,
properly categorized and ideally with project set to https://github.com/orgs/darktable-org/projects/1)
in darktable repo is the best and only thing.
Everything else simply increases my overhead, and, if i'm being perfectly honest,
simply defers me from dealing with all this stuff.
This isn't a great situation that darktable have found/placed itself in.

@kmilos
Copy link
Collaborator Author

kmilos commented Jun 9, 2021

I fully sympathize. I have not opened any of these new support requests, but only contributed PRs, and will make sure I don't link them to camera support issues from now on.

@johnny-bit Maybe the camera support issue template can be improved, and more explicit warnings to wiki added to avoid issue duplication, both within the darktable repo and across rawspeed?

@LebedevRI
Copy link
Member

I fully sympathize. I have not opened any of these new support requests, but only contributed PRs, and will make sure I don't link them to camera support issues from now on.

Note that i do really mean "Everything else".

@johnny-bit Maybe the camera support issue template can be improved, and more explicit warnings to wiki added to avoid issue duplication, both within the darktable repo and across rawspeed?

@johnny-bit
Copy link
Member

OK, Let's chat tomorrow on pixls.us irc so I fully understand "everything else" and I'll make sure to lower all overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Resolved

Development

Successfully merging this pull request may close these issues.

Sony Alpha 1 (ILCE-1)

5 participants