-
Notifications
You must be signed in to change notification settings - Fork 125
Support Sony ILCE-1 #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Sony ILCE-1 #274
Conversation
Max data after sample inspection
|
Any updates to this, the code changes seem to be quite trivial? |
|
Would really appreciate this getting in. Currently editing raw file metadata to say it's the A7Riv, but on opening, the default settings look dark. Works ok after adjustments, but having the camera supported would be great. |
|
@LebedevRI Great, thank you so much! |
|
@kmilos please stop using "fixes #xyz" in commit messages |
|
@LebedevRI noted - I assumed it would help w/ the "basic" triage, but now I see it might actually complicate schemes like "New Camera Support" cards you're using, sorry! |
|
IMHO only having a single camera support request issue (with meaningful name, |
|
I fully sympathize. I have not opened any of these new support requests, but only contributed PRs, and will make sure I don't link them to camera support issues from now on. @johnny-bit Maybe the camera support issue template can be improved, and more explicit warnings to wiki added to avoid issue duplication, both within the darktable repo and across rawspeed? |
Note that i do really mean "Everything else".
|
|
OK, Let's chat tomorrow on pixls.us irc so I fully understand "everything else" and I'll make sure to lower all overhead. |
Uses ARW DefaultCropOrigin+DefaultCropSize.Absolute (positive) size is used instead of the preferred relative (negative) one because the new JPEG lossless compressed ARW mode uses tiles and has a different (larger) ImageWidth/ImageLenght to the usual uncompressed & lossy compressed modes, so this should be future proof.
Closes darktable-org/darktable#8618 (w/o lossless compression; adobe_coeffs already in dt master)