Fix dependencies multi app build and add proper test deps #1572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@artur-ciocanu this one #1574 solves this pipeline issue. |
mcruzdev
approved these changes
Oct 19, 2025
artur-ciocanu
force-pushed
the
fix-jackson-version
branch
from
9103f91 to
5dd60f5
Compare
artur-ciocanu
changed the title
|
@dapr/approvers-java-sdk and @dapr/maintainers-java-sdk could you please review and approve. This is another PR that gets us closer to a more sane Maven config. Thank you. |
salaboy
reviewed
Oct 20, 2025
salaboy
reviewed
Oct 20, 2025
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
artur-ciocanu
force-pushed
the
fix-jackson-version
branch
from
d418a2e to
7f42d54
Compare
artur-ciocanu
changed the title
|
@salaboy @siri-varma could you please take a look, I have addressed the review comments. Thank you. |
cicoyle
approved these changes
Oct 21, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1572 +/- ##
============================================
+ Coverage 76.91% 78.44% +1.53%
- Complexity 1592 1929 +337
============================================
Files 145 216 +71
Lines 4843 5860 +1017
Branches 562 656 +94
============================================
+ Hits 3725 4597 +872
- Misses 821 926 +105
- Partials 297 337 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 24, 2025
* Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <[email protected]> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <[email protected]> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <[email protected]> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <[email protected]> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <[email protected]> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 24, 2025
* Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <[email protected]> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <[email protected]> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <[email protected]> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <[email protected]> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <[email protected]> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 24, 2025
* Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <[email protected]> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <[email protected]> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <[email protected]> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <[email protected]> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <[email protected]> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 24, 2025
* Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <[email protected]> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <[email protected]> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <[email protected]> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <[email protected]> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <[email protected]> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 24, 2025
* Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <[email protected]> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <[email protected]> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <[email protected]> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <[email protected]> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <[email protected]> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 24, 2025
* Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <[email protected]> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <[email protected]> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <[email protected]> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <[email protected]> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <[email protected]> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 24, 2025
* Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <[email protected]> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <[email protected]> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <[email protected]> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <[email protected]> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <[email protected]> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
dapr-bot
pushed a commit
that referenced
this pull request
Oct 24, 2025
* adding new method signature plus test Signed-off-by: salaboy <[email protected]> * re adding imports Signed-off-by: salaboy <[email protected]> * fixing style Signed-off-by: salaboy <[email protected]> * checking empty metadata Signed-off-by: salaboy <[email protected]> * copy meta for safety and check if key is present Signed-off-by: salaboy <[email protected]> * Centralize Maven dependency version management (#1564) Signed-off-by: salaboy <[email protected]> * Fix dependencies multi app build and add proper test deps (#1572) * Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <[email protected]> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <[email protected]> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <[email protected]> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <[email protected]> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <[email protected]> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]> * reverting pom Signed-off-by: salaboy <[email protected]> * fix codestyle Signed-off-by: salaboy <[email protected]> * using metaCopy Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: artur-ciocanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some instances the build was failing because of missing JARs when build the test containers in
examplesmodule. This PR ensures that we are relying onverifyphase to ensure all the JARs are present. Also there is a tiny fix to add proper<scope>test</scope>to different test dependencies.Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: