Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original implementation of the jobs mapping handler allowed the user to provide a
CancellationTokento the mapping. This unfortunately meant that long-running jobs mappers would fail when this timeout was hit because it was globally applied instead of applied to each request invocation, as intended.I've modified the approach to instead allow the user to pass an optional
TimeSpanindicating a timeout value to use. As part of the mapping, a newCancellationTokenis created using this timeout value, if provided (defaults toCancellationToken.Noneif not) so it's now performed on a per-request basis.I've also updated the example and unit tests to go along with this.
Thanks to @siri-varma for their research in identifying this issue.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1472
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: