Fix aws secrets manager yaml #4044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests for metadata parsing Signed-off-by: MyMirelHub <[email protected]>
MyMirelHub
force-pushed
the
fix-aws-secrets-manager-yaml
branch
from
02fc170 to
93db7a3
Compare
|
/ok-to-test |
nelson-parente
approved these changes
Sep 25, 2025
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 93db7a3 |
Components conformance testCommit ref: 93db7a3 ❌ Some conformance tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Components certification testCommit ref: 93db7a3 ❌ Some certification tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced the JSON marshal/unmarshal approach in
getSecretManagerMetadatawithkitmd.DecodeMetadatato properly handle string-to-boolean conversion for themultipleKeyValuesPerSecretfield.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #4045
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.