Skip to content

Loop with skips of 1000 to avoid hitting graph limit #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2020
Merged

Loop with skips of 1000 to avoid hitting graph limit #535

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc60a81
loop with skips of 1000 to avoid hitting graph limit
roienatan Sep 9, 2020
f7a1cff
added constant for max subgraph query ; less unneccessary queries
roienatan Sep 10, 2020
dd8b777
added push condition
roienatan Sep 10, 2020
b9200d5
bump version
roienatan Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 33 additions & 13 deletions src/arc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ import {
} from './index'

const abis = require('./abis/abis.json')
const MAX_BATCH_QUERY = 1000

export type IArcOptions = IApolloClientOptions & {
/** Information about the contracts. Cf. [[setContractInfos]] and [[fetchContractInfos]] */
Expand Down Expand Up @@ -203,14 +204,20 @@ export class Arc extends GraphNodeObserver {

/**
* fetch contractInfos from the subgraph
* we skip the first max batch query each iteration to avoid hitting subgraph limit
* @return a list of IContractInfo instances
*/
public async fetchContractInfos(
apolloQueryOptions: IApolloQueryOptions = {}
): Promise<IContractInfo[]> {
const query = gql`
const allContractInfos = []
let contractInfos = []
let skip = 0

do {
const query = gql`
query AllContractInfos {
contractInfos(first: 1000) {
contractInfos(first: ${MAX_BATCH_QUERY} skip: ${skip * MAX_BATCH_QUERY}) {
id
name
version
Expand All @@ -219,25 +226,34 @@ export class Arc extends GraphNodeObserver {
}
}
`
// const result = await this.getObservableList(query, itemMap, apolloQueryOptions).pipe(first()).toPromise()
const response = await this.sendQuery(query, apolloQueryOptions)
const contractInfos = response.data.contractInfos as IContractInfo[]
const response = await this.sendQuery(query, apolloQueryOptions)
contractInfos = response.data.contractInfos as IContractInfo[]
allContractInfos.push(...contractInfos)
skip++
} while (contractInfos.length === MAX_BATCH_QUERY)

const universalContractInfos = await this.fetchUniversalContractInfos()
contractInfos.push(...universalContractInfos)
this.setContractInfos(contractInfos)
return contractInfos
allContractInfos.push(...universalContractInfos)
this.setContractInfos(allContractInfos)
return allContractInfos
}

/**
* fetch universalContractInfos from the subgraph
* we skip the first max batch query each iteration to avoid hitting subgraph limit
* @return a list of IContractInfo instances
*/
public async fetchUniversalContractInfos(
apolloQueryOptions: IApolloQueryOptions = {}
): Promise<IContractInfo[]> {
const query = gql`
const allUniversalContractInfos = []
let universalContractInfos = []
let skip = 0

do {
const query = gql`
query AllUniversalContractInfos {
universalContractInfos(first: 1000) {
universalContractInfos(first: ${MAX_BATCH_QUERY} skip: ${skip * MAX_BATCH_QUERY}) {
id
name
version
Expand All @@ -246,9 +262,13 @@ export class Arc extends GraphNodeObserver {
}
}
`
const response = await this.sendQuery(query, apolloQueryOptions)
const result = response.data.universalContractInfos as IContractInfo[]
return result
const response = await this.sendQuery(query, apolloQueryOptions)
universalContractInfos = response.data.universalContractInfos as IContractInfo[]
allUniversalContractInfos.push(...universalContractInfos)
skip++
} while (universalContractInfos.length === MAX_BATCH_QUERY)

return allUniversalContractInfos
}

/**
Expand Down