Fix for scenario when destination is false #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous check would evaluate to `false` if the value is `false`. We should instead check if the key exists, and not check truthiness.
Collaborator
|
@ameir Can you add a spec for this? |
Collaborator
|
See also #23 |
Author
|
@Fryguy thanks for looking this over; I've added a test case to this PR. Please let me know if you need any further adjustments. |
Author
|
@Fryguy FWIW, it looks like Chef made a similar update to their fork: |
|
Hello there, just wanted to check what else would be required to get this fix merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous check would evaluate to
falseif the value isfalse. We should instead check if the key exists, and not check truthiness.