Skip to content

fix(driver): update wrapErr to ignore number and boolean values #20172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2022
Merged

fix(driver): update wrapErr to ignore number and boolean values #20172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b26426
fix(driver): update `wrapErr` to ignore non-serializable errors
alikirec Feb 14, 2022
17287bd
return
alikirec Feb 14, 2022
bebaa93
unit test: boolean case
alikirec Feb 14, 2022
a3b42df
Merge branch 'develop' into issue-19561-wrapp-err
emilyrohrbough Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/driver/cypress/integration/cypress/error_utils_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,4 +622,18 @@ describe('driver/src/cypress/error_utils', () => {
expect(stack).not.to.include('removeMeAndAbove')
})
})

context('.wrapErr', () => {
[
{ value: undefined, label: 'undefined' },
{ value: null, label: 'null' },
{ value: '', label: 'empty string' },
{ value: true, label: 'boolean' },
{ value: 1, label: 'number' },
].forEach((err) => {
it(`returns undefined if err is ${err.label}`, () => {
expect($errUtils.wrapErr(err.value)).to.be.undefined
})
})
})
})
8 changes: 7 additions & 1 deletion packages/driver/src/cypress/error_utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,14 @@ const prepareErrorForSerialization = (err) => {
return err
}

// some errors, probably from user callbacks, might be boolean, number or falsy values
// which means serializing will not provide any useful context
const isSerializableError = (err) => {
return !!err && (typeof err === 'object' || typeof err === 'string')
}

const wrapErr = (err) => {
if (!err) return
if (!isSerializableError(err)) return

prepareErrorForSerialization(err)

Expand Down