-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: minimum linux requirements for electron 36 #6219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cypress-documentation
|
Project |
cypress-documentation
|
Branch Review |
glibc-electron-36
|
Run status |
|
Run duration | 04m 55s |
Commit |
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
308
|
View all changes introduced in this branch ↗︎ |
UI Coverage
10.97%
|
|
---|---|
|
2444
|
|
3
|
Accessibility
96.94%
|
|
---|---|
|
1 critical
3 serious
4 moderate
0 minor
|
|
26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cacieprins I'm kind of not a fan overall of the table. It seems like it's highlighting what we don't support a lot more than we should. How long do we keep old OS's in this table for? It'd be simpler to only document what we DO support, which is what the existing doc does.
| Distribution | Version | Cypress 14 | Cypress 15 | | ||
| ------------------ | ---------------- | ---------- | ---------- | | ||
| **macOS** | 10.15 (Catalina) | ❌ | ❌ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest removing the Cypress 14 column. The docs are meant to reflect 'current version' always aside from the Changelog and Migration Guide docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is is possible to add this and then add a commit that removes it and we rebase merge the commits into the main branch so we at least have the historical record some place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add this table! It makes it horribly complicated and difficult to maintain.
You're not really testing against all these operating systems and versions and listing them all is creating a whole lot of unnecessary support exposure.
99% of users are on Ubuntu / Debian / Fedora / Windows / macOS as can be seen from issues reported
4a94500
to
e788931
Compare
Prebuilt binaries for Linux are no longer compatible with Linux distributions based on glibc `<2.31`. | ||
This support is in line with Node.js's support for Linux in 20+. | ||
|
||
If you're using a Linux distribution based on glibc `<2.31`, for example, Ubuntu 18.04, RHEL 8, CentOS 8, AlmaLinux 8, Rocky Linux 8, you'll need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it is true that Ubuntu 18 won't work with Cypress 15, it was already removed in 2023 - see #5515 because it didn't meet the previous criteria for minimum glibc 2.28. So it could probably be removed from the list here. That is to say it is not compatible with Cypress 14 either, so it's nothing new for Cypress 15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for background information - attempting to install Cypress 14 on Ubuntu 18.04 definitely doesn't work:
$ n 16
copying : node/16.20.2
installed : v16.20.2 (with npm 8.19.4)
$ yarn add cypress
yarn add v1.22.22
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "^18.0.0 || ^20.0.0 || >=22.0.0". Got "16.20.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
$ n 18
installing : node-v18.20.8
mkdir : /home/mike/n/n/versions/node/18.20.8
fetch : https://nodejs.org/dist/v18.20.8/node-v18.20.8-linux-x64.tar.xz
copying : node/18.20.8
node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by node)
/home/mike/n/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /home/mike/n/bin/node)
installed : (with npm )
Co-authored-by: Mike McCready <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for making this change simpler and maintainable!
* chore: remove CDP deprecation notice in launching browsers related to firefox (#6116) * chore: Node.js 18/23 removal (#6138) * Update Node.js versions that will be supported for 15 * update lowest npm version supported * chore: update typescript docs to tsx (#6155) * chore: remove ts-node references and workarounds and replace them with tsx * add empty changelog entry for 15 to allow for linked out changes to build * chore: add beginning of migration guide for Cypress 15 (#6159) * chore: add begining of migration guide for Cypress 15 * Update docs/app/references/migration-guide.mdx Co-authored-by: Mike McCready <[email protected]> * Update docs/app/references/migration-guide.mdx Co-authored-by: Mike McCready <[email protected]> * Update docs/app/references/migration-guide.mdx Co-authored-by: Mike McCready <[email protected]> --------- Co-authored-by: Mike McCready <[email protected]> * chore: make the minimum version of angular 18+ (#6168) * chore: add webpack 4 migration guide / workarounds (#6164) * chore: merge dev into 15 (#6172) * Add Windows 2025 to supported OS list (#6142) * New user roles and permissions defined (#6143) * chore: release 14.3.0 documentation (#6144) * feat: documentation for the press() command (#6135) * docs for the press() command, including a callout in the accessibility guide * add press to TOC * Move some content around, mention accesiibility * remove 'focus' note * Document Keyboard.Keys * update reference to command * Update example to be a little more real case * Add another example of autocomplete with tab * Add link to keyboard api page * Fix version number for introduction * Fix broken link * alphabetize see also * Update package.json Co-authored-by: Mike McCready <[email protected]> * Fix broken link * lint --------- Co-authored-by: Jennifer Shehane <[email protected]> Co-authored-by: Mike McCready <[email protected]> * chore: add 14.3.0 changelog to documentation * Update docs/app/guides/accessibility-testing.mdx * Update docs/app/references/changelog.mdx Co-authored-by: Bill Glesias <[email protected]> --------- Co-authored-by: Cacie Prins <[email protected]> Co-authored-by: Jennifer Shehane <[email protected]> Co-authored-by: Mike McCready <[email protected]> * Correct parameter usage for click() in shadow.mdx (#6145) * Update shadow.mdx - Update the suggestion to pass 'top' to cy.click() using the options defined in cy.click()'s documentation * Update shadow.mdx Add missing quote * Update shadow.mdx One-line for prettier reasons * Correct command syntax (#6148) Adds the missing `s` to `Cypress.Command.overwrite()` * extend pnpm config instructions (#6149) * fix cy.origin() "yielding a value" example (#6152) * Update results-api.mdx (#6150) * chore: add 14.3.1 changelog (#6153) * chore: add 14.3.1 changelog * Update docs/app/references/changelog.mdx Co-authored-by: Mike McCready <[email protected]> * empty commit to rekick build --------- Co-authored-by: Mike McCready <[email protected]> * docs: harmonize on injectDocumentDomain removal in future version (#6154) * Add experimentalSessionAndOrigin removed comment to origin video (#6158) * Fix "cy.visit() succeeded, but commands are timing out" error example (#6157) * Cross-link cy.origin and injectDocumentDomain (#6156) * chore: add cypress 14.3.2 changelog (#6160) * Change 'add on' to 'premium solution' for UI Cov & a11y products (#6162) * UI Coverage and Branch Review updates (#6167) * add AQ links and button space * use onlinks for demo vids * update Cypress * content updates * content tweaks * add last images * lint-fix * simplify * add detail view docs and clean up * lint fix * Update docs/cloud/get-started/introduction.mdx Co-authored-by: Mike McCready <[email protected]> * Update docs/ui-coverage/core-concepts/compare-reports.mdx Co-authored-by: Mike McCready <[email protected]> * Update docs/ui-coverage/core-concepts/compare-reports.mdx Co-authored-by: Mike McCready <[email protected]> * revert cypress version bump * restore package-lock * remove yarn lockfile * Update docs/app/get-started/why-cypress.mdx Co-authored-by: Tyler Biethman <[email protected]> * Update docs/cloud/features/branch-review.mdx Co-authored-by: Tyler Biethman <[email protected]> * Update docs/cloud/features/branch-review.mdx Co-authored-by: Tyler Biethman <[email protected]> --------- Co-authored-by: Mike McCready <[email protected]> Co-authored-by: Tyler Biethman <[email protected]> * chore: add 14.3.3 changelog (#6171) * chore: add 14.3.3 changelog * Update docs/app/references/changelog.mdx Co-authored-by: Matt Schile <[email protected]> --------- Co-authored-by: Matt Schile <[email protected]> * Rework instructions for missing Cypress binary in CI (#6170) * Node.js 18 EOL (#6165) * Add quoting advice for PowerShell CLI options (#6169) * Add quoting advice for PowerShell CLI options * Fix --config typo Co-authored-by: Jennifer Shehane <[email protected]> --------- Co-authored-by: Jennifer Shehane <[email protected]> * Bump Cypress Docker versions in examples to Node.js 22.15.0 LTS (#6161) --------- Co-authored-by: Mike McCready <[email protected]> Co-authored-by: danjohansenconsulting <[email protected]> Co-authored-by: Cacie Prins <[email protected]> Co-authored-by: Jennifer Shehane <[email protected]> Co-authored-by: Matthew Sbar <[email protected]> Co-authored-by: Tim Rayers <[email protected]> Co-authored-by: Emily Wisniewski (Rohrbough) <[email protected]> Co-authored-by: Mark Noonan <[email protected]> Co-authored-by: Tyler Biethman <[email protected]> Co-authored-by: Matt Schile <[email protected]> Co-authored-by: Jennifer Shehane <[email protected]> * Revert "chore: merge dev into 15 (#6172)" (#6174) This reverts commit 6af2913. * chore: add migration guide for`@cypress/webpack-batteries-included-preprocessor` built-ins removal (#6192) * chore: add migration guide if needing webpack built-ins * Update docs/app/references/migration-guide.mdx Co-authored-by: Jennifer Shehane <[email protected]> * run linter --------- Co-authored-by: Jennifer Shehane <[email protected]> * baseline updates for Cypress Studio updates * Updates for renaming SelectorPlayground to ElementSelector API (#6212) * Updates for SelectorPlayground to ElementSelector * add migration section for SelectorPlayground renaming * remove links to selector-playgroun-api * lint * Update docs/app/references/migration-guide.mdx Co-authored-by: Emily Wisniewski (Rohrbough) <[email protected]> * Update docs/app/references/migration-guide.mdx Co-authored-by: Emily Wisniewski (Rohrbough) <[email protected]> * Update docs/app/references/migration-guide.mdx Co-authored-by: Mike McCready <[email protected]> * Update docs/app/references/migration-guide.mdx Co-authored-by: Mike McCready <[email protected]> * Update docs/api/cypress-api/element-selector-api.mdx Co-authored-by: Mike McCready <[email protected]> * remove note about Node.js 18 being deprecated * Update docs/app/guides/cypress-studio.mdx Co-authored-by: Mike McCready <[email protected]> * Update docs/app/references/migration-guide.mdx Co-authored-by: Mike McCready <[email protected]> * Update docs/app/references/migration-guide.mdx Co-authored-by: Mike McCready <[email protected]> * docs: minimum linux requirements for electron 36 (#6219) * minimum linux requirements for electron 36 * fix deb 10 ref for cy 14 * rm tables, make concise * Update docs/app/get-started/install-cypress.mdx * Update docs/app/references/migration-guide.mdx * Update docs/app/references/migration-guide.mdx Co-authored-by: Mike McCready <[email protected]> --------- Co-authored-by: Jennifer Shehane <[email protected]> Co-authored-by: Mike McCready <[email protected]> * chore: document vite 4 removal and vite 7 support for ct (#6224) * Rewrite to make its use more understandable + remove getSelector (#6235) * Rewrite to make its use more understandable + remove getSelector * Add more examples + simplify * lint * add note about uniqueness of selector * lint * Remove redundant aria-label * Add notes about the variability of the ElementSelector API and the de… (#6238) * Add notes about the variability of the ElementSelector API and the deprecation of Selector Playground * update info areas * lint fix * Add new screenshots that match Cypress 15 design (#6240) * begin added images of newly designed app * add more 15 images * lint * Add more specific content + videos for Studio (#6245) * Add a video for editing in studio * More updates for Studio docs * lint fix * add last video * Add limitation around cypress/grep + existing issues link * chore: update CT docs and migration guide (#6248) * chore: update docs with supported angular versions, webpack versions, and migration guide helpers * fix linter issues --------- Co-authored-by: Jennifer Shehane <[email protected]> * chore: update code to exitCode in `cy.exec()` (#6247) * chore: update code to exitCode * add history to exec * Add short migration descriptions * chore: fix linter issues --------- Co-authored-by: Jennifer Shehane <[email protected]> Co-authored-by: Jennifer Shehane <[email protected]> * Update install page to remove direct download (#6249) * Update install page * lint + link fix * typo * typo * Update docs/app/get-started/install-cypress.mdx Co-authored-by: Mike McCready <[email protected]> * updates for broken links + semver versions + ubuntu/debian updates * lint * lint --------- Co-authored-by: Mike McCready <[email protected]> * commit summary for changelog * chore: add Release 15.0.0 changelog (#6252) --------- Co-authored-by: Bill Glesias <[email protected]> Co-authored-by: Mike McCready <[email protected]> Co-authored-by: danjohansenconsulting <[email protected]> Co-authored-by: Cacie Prins <[email protected]> Co-authored-by: Matthew Sbar <[email protected]> Co-authored-by: Tim Rayers <[email protected]> Co-authored-by: Emily Wisniewski (Rohrbough) <[email protected]> Co-authored-by: Mark Noonan <[email protected]> Co-authored-by: Tyler Biethman <[email protected]> Co-authored-by: Matt Schile <[email protected]>
Close #6214